2013-01-10 17:35:12 +00:00
|
|
|
|
Adjust the mysql-log-rotate script in several ways:
|
|
|
|
|
|
|
|
|
|
* Use the correct log file pathname for Red Hat installations.
|
|
|
|
|
* Enable creation of the log file by logrotate (needed since
|
|
|
|
|
/var/log/ isn't writable by mysql user); and set the same 640
|
|
|
|
|
permissions we normally use.
|
|
|
|
|
* Comment out the actual rotation commands, so that user must edit
|
|
|
|
|
the file to enable rotation. This is unfortunate, but the fact
|
|
|
|
|
that the script will probably fail without manual configuration
|
|
|
|
|
(to set a root password) means that we can't really have it turned
|
|
|
|
|
on by default. Fortunately, in most configurations the log file
|
|
|
|
|
is low-volume and so rotation is not critical functionality.
|
|
|
|
|
|
|
|
|
|
See discussions at RH bugs 799735, 547007
|
2017-05-23 13:14:48 +00:00
|
|
|
|
* Note they are from Fedora 15 / 16
|
|
|
|
|
|
|
|
|
|
Update 3/2017
|
|
|
|
|
* it would be big unexpected change for anyone upgrading, if we start shipping it now.
|
|
|
|
|
Maybe it is good candidate for shipping with MariaDB 10.2 ?
|
|
|
|
|
* the 'mysqladmin flush logs' doesn´t guarantee, no entries are lost
|
|
|
|
|
during flushing, the operation is not atomic.
|
|
|
|
|
We should not ship it in that state
|
2013-01-10 17:35:12 +00:00
|
|
|
|
|
2018-06-27 14:01:22 +00:00
|
|
|
|
Update 6/2018
|
|
|
|
|
* the SIGHUP causes server to flush all logs. No password admin needed, the only constraint is
|
|
|
|
|
beeing able to send the SIGHUP to the process and read the mysqld pid file, which root can.
|
2018-06-29 00:21:45 +00:00
|
|
|
|
* Submited as PR: https://github.com/MariaDB/server/pull/807
|
2018-06-27 14:01:22 +00:00
|
|
|
|
|
|
|
|
|
--- mariadb-10.3.7/support-files/mysql-log-rotate.sh 2018-05-23 22:38:46.000000000 +0200
|
|
|
|
|
+++ mariadb-10.3.7/support-files/mysql-log-rotate.sh_patched 2018-06-27 12:11:23.705719826 +0200
|
|
|
|
|
@@ -1,25 +1,12 @@
|
2013-08-29 14:02:55 +00:00
|
|
|
|
# This logname can be set in /etc/my.cnf
|
2018-06-27 14:01:22 +00:00
|
|
|
|
# by setting the variable "err-log"
|
2013-08-29 14:02:55 +00:00
|
|
|
|
-# in the [safe_mysqld] section as follows:
|
2018-06-29 00:21:45 +00:00
|
|
|
|
+# in the [mysqld] section as follows:
|
2013-01-10 17:35:12 +00:00
|
|
|
|
#
|
2013-08-29 14:02:55 +00:00
|
|
|
|
-# [safe_mysqld]
|
2013-01-10 17:35:12 +00:00
|
|
|
|
-# err-log=@localstatedir@/mysqld.log
|
2018-06-27 14:01:22 +00:00
|
|
|
|
-#
|
|
|
|
|
-# If the root user has a password you have to create a
|
|
|
|
|
-# /root/.my.cnf configuration file with the following
|
|
|
|
|
-# content:
|
|
|
|
|
-#
|
|
|
|
|
-# [mysqladmin]
|
|
|
|
|
-# password = <secret>
|
|
|
|
|
-# user= root
|
|
|
|
|
-#
|
|
|
|
|
-# where "<secret>" is the password.
|
|
|
|
|
-#
|
|
|
|
|
-# ATTENTION: This /root/.my.cnf should be readable ONLY
|
|
|
|
|
-# for root !
|
2018-06-29 00:21:45 +00:00
|
|
|
|
+# [mysqld]
|
|
|
|
|
+# log_error=@LOG_LOCATION@
|
2013-01-10 17:35:12 +00:00
|
|
|
|
|
|
|
|
|
-@localstatedir@/mysqld.log {
|
|
|
|
|
- # create 600 mysql mysql
|
2018-06-27 14:01:22 +00:00
|
|
|
|
+@LOG_LOCATION@ {
|
|
|
|
|
+ create 600 mysql mysql
|
|
|
|
|
notifempty
|
|
|
|
|
daily
|
|
|
|
|
rotate 3
|
|
|
|
|
@@ -27,11 +14,9 @@
|
|
|
|
|
compress
|
|
|
|
|
postrotate
|
|
|
|
|
# just if mysqld is really running
|
2013-01-10 17:35:12 +00:00
|
|
|
|
- if test -x @bindir@/mysqladmin && \
|
|
|
|
|
- @bindir@/mysqladmin ping &>/dev/null
|
|
|
|
|
- then
|
2017-05-24 09:25:52 +00:00
|
|
|
|
- @bindir@/mysqladmin --local flush-error-log \
|
|
|
|
|
- flush-engine-log flush-general-log flush-slow-log
|
2013-01-10 17:35:12 +00:00
|
|
|
|
- fi
|
2018-06-27 14:01:22 +00:00
|
|
|
|
+ if [ -e @PID_FILE_DIR@/@DAEMON_NO_PREFIX@.pid ]
|
|
|
|
|
+ then
|
|
|
|
|
+ kill -1 $(<@PID_FILE_DIR@/@DAEMON_NO_PREFIX@.pid)
|
|
|
|
|
+ fi
|
|
|
|
|
endscript
|
|
|
|
|
}
|