42 lines
1.2 KiB
Diff
42 lines
1.2 KiB
Diff
|
From 245b70d7d2768572ae1b05b3668ca858b9ec4ed4 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Nick Wellnhofer <wellnhofer@aevum.de>
|
||
|
|
Date: Tue, 10 Dec 2024 16:52:05 +0100
|
||
|
|
Subject: [PATCH] [CVE-2024-56171] Fix use-after-free after
|
||
|
|
xmlSchemaItemListAdd
|
||
|
|
|
||
|
|
xmlSchemaItemListAdd can reallocate the items array. Update local
|
||
|
|
variables after adding item in
|
||
|
|
|
||
|
|
- xmlSchemaIDCFillNodeTables
|
||
|
|
- xmlSchemaBubbleIDCNodeTables
|
||
|
|
|
||
|
|
Fixes #828.
|
||
|
|
---
|
||
|
|
xmlschemas.c | 3 +++
|
||
|
|
1 file changed, 3 insertions(+)
|
||
|
|
|
||
|
|
diff --git a/xmlschemas.c b/xmlschemas.c
|
||
|
|
index d276faf10..28b14bd44 100644
|
||
|
|
--- a/xmlschemas.c
|
||
|
|
+++ b/xmlschemas.c
|
||
|
|
@@ -23388,6 +23388,7 @@ xmlSchemaIDCFillNodeTables(xmlSchemaValidCtxtPtr vctxt,
|
||
|
|
}
|
||
|
|
if (xmlSchemaItemListAdd(bind->dupls, bind->nodeTable[j]) == -1)
|
||
|
|
goto internal_error;
|
||
|
|
+ dupls = (xmlSchemaPSVIIDCNodePtr *) bind->dupls->items;
|
||
|
|
/*
|
||
|
|
* Remove the duplicate entry from the IDC node-table.
|
||
|
|
*/
|
||
|
|
@@ -23604,6 +23605,8 @@ xmlSchemaBubbleIDCNodeTables(xmlSchemaValidCtxtPtr vctxt)
|
||
|
|
goto internal_error;
|
||
|
|
}
|
||
|
|
xmlSchemaItemListAdd(parBind->dupls, parNode);
|
||
|
|
+ dupls = (xmlSchemaPSVIIDCNodePtr *)
|
||
|
|
+ parBind->dupls->items;
|
||
|
|
} else {
|
||
|
|
/*
|
||
|
|
* Add the node-table entry (node and key-sequence) of
|
||
|
|
--
|
||
|
|
GitLab
|
||
|
|
|