8026296455
- util: introduce object for holding a system inhibitor lock (RHEL-83064) - src: convert drivers over to new virInhibitor APIs (RHEL-83064) - rpc: remove logind support for virNetDaemon (RHEL-83064) - util: fix off-by-1 in inhibitor constants (RHEL-83064) - util: don't attempt to acquire logind inhibitor if not requested (RHEL-83064) - network: Free inhibitor in networkStateCleanup() (RHEL-83064) - conf: introduce support for multiple ACPI tables (RHEL-81041) - src: validate permitted ACPI table types in libxl/qemu drivers (RHEL-81041) - src: introduce 'raw' and 'rawset' ACPI table types (RHEL-81041) - qemu: support 'raw' ACPI table type (RHEL-81041) - libxl: support 'rawset' ACPI table type (RHEL-81041) - conf: support MSDM ACPI table type (RHEL-81041) - qemu: support MSDM ACPI table type (RHEL-81041) - qemuxmlconftest: Include shared memory 'net-vhostuser' test cases (RHEL-84133) - qemuValidateDomainDeviceDefNetwork: Require shared memory for all vhost-user interfaces (RHEL-84133) - qemu: process: Remove un-updated 'qemuProcessStartWarnShmem' (RHEL-84133) Resolves: RHEL-81041, RHEL-83064, RHEL-84133
95 lines
3.1 KiB
Diff
95 lines
3.1 KiB
Diff
From f61b747b0420d71efe33f836a1117d4741ecd716 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <f61b747b0420d71efe33f836a1117d4741ecd716.1742990721.git.jdenemar@redhat.com>
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
|
Date: Tue, 11 Mar 2025 09:04:18 +0100
|
|
Subject: [PATCH] qemu: process: Remove un-updated 'qemuProcessStartWarnShmem'
|
|
|
|
The checks in qemuProcessStartWarnShmem are no longer current. Since
|
|
previous patch made it fatal for vhost-user interfaces to be configured
|
|
without shared memory this warning code can be deleted.
|
|
|
|
Resolves: https://issues.redhat.com/browse/RHEL-80533
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
|
|
(cherry picked from commit 080c7fd341619a3d1986a00265addaf45b63aacf)
|
|
|
|
https://issues.redhat.com/browse/RHEL-84133
|
|
---
|
|
src/qemu/qemu_process.c | 54 -----------------------------------------
|
|
1 file changed, 54 deletions(-)
|
|
|
|
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
|
|
index 722e982b9e..fac5678439 100644
|
|
--- a/src/qemu/qemu_process.c
|
|
+++ b/src/qemu/qemu_process.c
|
|
@@ -5406,56 +5406,6 @@ qemuProcessMakeDir(virQEMUDriver *driver,
|
|
}
|
|
|
|
|
|
-static void
|
|
-qemuProcessStartWarnShmem(virDomainObj *vm)
|
|
-{
|
|
- size_t i;
|
|
- bool check_shmem = false;
|
|
- bool shmem = vm->def->nshmems;
|
|
-
|
|
- /*
|
|
- * For vhost-user to work, the domain has to have some type of
|
|
- * shared memory configured. We're not the proper ones to judge
|
|
- * whether shared hugepages or shm are enough and will be in the
|
|
- * future, so we'll just warn in case neither is configured.
|
|
- * Moreover failing would give the false illusion that libvirt is
|
|
- * really checking that everything works before running the domain
|
|
- * and not only we are unable to do that, but it's also not our
|
|
- * aim to do so.
|
|
- */
|
|
- for (i = 0; i < vm->def->nnets; i++) {
|
|
- if (virDomainNetGetActualType(vm->def->nets[i]) ==
|
|
- VIR_DOMAIN_NET_TYPE_VHOSTUSER) {
|
|
- check_shmem = true;
|
|
- break;
|
|
- }
|
|
- }
|
|
-
|
|
- if (!check_shmem)
|
|
- return;
|
|
-
|
|
- /*
|
|
- * This check is by no means complete. We merely check
|
|
- * whether there are *some* hugepages enabled and *some* NUMA
|
|
- * nodes with shared memory access.
|
|
- */
|
|
- if (!shmem && vm->def->mem.nhugepages) {
|
|
- for (i = 0; i < virDomainNumaGetNodeCount(vm->def->numa); i++) {
|
|
- if (virDomainNumaGetNodeMemoryAccessMode(vm->def->numa, i) ==
|
|
- VIR_DOMAIN_MEMORY_ACCESS_SHARED) {
|
|
- shmem = true;
|
|
- break;
|
|
- }
|
|
- }
|
|
- }
|
|
-
|
|
- if (!shmem) {
|
|
- VIR_WARN("Detected vhost-user interface without any shared memory, "
|
|
- "the interface might not be operational");
|
|
- }
|
|
-}
|
|
-
|
|
-
|
|
static int
|
|
qemuProcessStartValidateGraphics(virDomainObj *vm)
|
|
{
|
|
@@ -5690,10 +5640,6 @@ qemuProcessStartValidate(virQEMUDriver *driver,
|
|
if (qemuProcessStartValidateTSC(driver, vm) < 0)
|
|
return -1;
|
|
|
|
- VIR_DEBUG("Checking for any possible (non-fatal) issues");
|
|
-
|
|
- qemuProcessStartWarnShmem(vm);
|
|
-
|
|
return 0;
|
|
}
|
|
|
|
--
|
|
2.49.0
|