9ea8eed2bd
- remote_driver: Restore special behavior of remoteDomainGetBlockIoTune() (RHEL-22800) - conf: Introduce dynamicMemslots attribute for virtio-mem (RHEL-15316) - qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_DYNAMIC_MEMSLOTS capability (RHEL-15316) - qemu_validate: Check capability for virtio-mem dynamicMemslots (RHEL-15316) - qemu_command: Generate cmd line for virtio-mem dynamicMemslots (RHEL-15316) - qemu_snapshot: fix detection if non-leaf snapshot isn't in active chain (RHEL-23212) - qemu_snapshot: create: refactor external snapshot detection (RHEL-22797) - qemu_snapshot: create: don't require disk-only flag for offline external snapshot (RHEL-22797) - remoteDispatchAuthPolkit: Fix lock ordering deadlock if client closes connection during auth (RHEL-20337) - util: virtportallocator: Add VIR_DEBUG statements for port allocations and release (RHEL-21543) - qemu: migration: Properly handle reservation of manually specified NBD port (RHEL-21543) - qemuMigrationDstStartNBDServer: Refactor cleanup (RHEL-21543) - virPCIVPDResourceIsValidTextValue: Adjust comment to reflect actual code (RHEL-22314) - util: pcivpd: Refactor virPCIVPDResourceIsValidTextValue (RHEL-22314) - virNodeDeviceCapVPDFormatCustom*: Escape unsanitized strings (RHEL-22314) - virNodeDeviceCapVPDFormat: Properly escape system-originated strings (RHEL-22314) - schema: nodedev: Adjust allowed characters in 'vpdFieldValueFormat' (RHEL-22314) - tests: Test the previously mishandled PCI VPD characters (RHEL-22314) - Don't overwrite error message from 'virXPathNodeSet' (RHEL-22314) - tests: virpcivpdtest: Remove 'testVirPCIVPDReadVPDBytes' case (RHEL-22314) - util: virpcivpd: Unexport 'virPCIVPDReadVPDBytes' (RHEL-22314) - util: pcivpd: Unexport virPCIVPDParseVPDLargeResourceFields (RHEL-22314) - tests: virpcivpd: Remove 'testVirPCIVPDParseVPDStringResource' case (RHEL-22314) - util: virpcivpd: Unexport 'virPCIVPDParseVPDLargeResourceString' (RHEL-22314) - virPCIVPDResourceGetKeywordPrefix: Fix logging (RHEL-22314) - util: virpcivpd: Remove return value from virPCIVPDResourceCustomUpsertValue (RHEL-22314) - conf: virNodeDeviceCapVPDParse*: Remove pointless NULL checks (RHEL-22314) - virpcivpdtest: testPCIVPDResourceBasic: Remove tests for uninitialized 'ro'/'rw' section (RHEL-22314) - util: virPCIVPDResourceUpdateKeyword: Remove impossible checks (RHEL-22314) - conf: node_device: Refactor 'virNodeDeviceCapVPDParseCustomFields' to fix error reporting (RHEL-22314) - virNodeDeviceCapVPDParseXML: Fix error reporting (RHEL-22314) - util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword (RHEL-22314) - virPCIDeviceHasVPD: Refactor "debug" messages (RHEL-22314) - virPCIDeviceGetVPD: Fix multiple error handling bugs (RHEL-22314) - virPCIDeviceGetVPD: Handle errors in callers (RHEL-22314) - virPCIVPDReadVPDBytes: Refactor error handling (RHEL-22314) - virPCIVPDParseVPDLargeResourceString: Properly report errors (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Merge logic conditions (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Remove impossible 'default' switch case (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Refactor processing of read data (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Refactor return logic (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Report proper errors (RHEL-22314) - virPCIVPDParse: Do reasonable error reporting (RHEL-22314) - virt-admin: Add warning when connection to default daemon fails (RHEL-23170) Resolves: RHEL-15316, RHEL-20337, RHEL-21543, RHEL-22314, RHEL-22797 Resolves: RHEL-22800, RHEL-23170, RHEL-23212
84 lines
3.0 KiB
Diff
84 lines
3.0 KiB
Diff
From c4b66437f7b829efa0ab6c6007347061ca257719 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <c4b66437f7b829efa0ab6c6007347061ca257719.1707394627.git.jdenemar@redhat.com>
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
|
Date: Wed, 24 Jan 2024 14:55:47 +0100
|
|
Subject: [PATCH] tests: virpcivpdtest: Remove 'testVirPCIVPDReadVPDBytes' case
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The case checks only the 'virPCIVPDReadVPDBytes' which is also tested
|
|
multiple times via 'virPCIVPDParse' as it's used to read the data, thus
|
|
having a special case for this is pointless.
|
|
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
(cherry picked from commit 1a994a9dc6424ff7ea9d0f5d325059ffd234408b)
|
|
|
|
https://issues.redhat.com/browse/RHEL-22314 [9.4.0]
|
|
---
|
|
tests/virpcivpdtest.c | 41 -----------------------------------------
|
|
1 file changed, 41 deletions(-)
|
|
|
|
diff --git a/tests/virpcivpdtest.c b/tests/virpcivpdtest.c
|
|
index ae5772d3f5..aadd1b222b 100644
|
|
--- a/tests/virpcivpdtest.c
|
|
+++ b/tests/virpcivpdtest.c
|
|
@@ -429,45 +429,6 @@ testPCIVPDGetFieldValueFormat(const void *data G_GNUC_UNUSED)
|
|
'Y', 'E', 0x00, \
|
|
'R', 'W', 0x02, 0x00, 0x00
|
|
|
|
-static int
|
|
-testVirPCIVPDReadVPDBytes(const void *opaque G_GNUC_UNUSED)
|
|
-{
|
|
- VIR_AUTOCLOSE fd = -1;
|
|
- g_autofree uint8_t *buf = NULL;
|
|
- uint8_t csum = 0;
|
|
- size_t readBytes = 0;
|
|
- size_t dataLen = 0;
|
|
-
|
|
- /* An example of a valid VPD record with one VPD-R resource and 2 fields. */
|
|
- uint8_t fullVPDExample[] = {
|
|
- VPD_STRING_RESOURCE_EXAMPLE_HEADER, VPD_STRING_RESOURCE_EXAMPLE_DATA,
|
|
- VPD_R_FIELDS_EXAMPLE_HEADER, VPD_R_FIELDS_EXAMPLE_DATA,
|
|
- PCI_VPD_RESOURCE_END_VAL
|
|
- };
|
|
- dataLen = G_N_ELEMENTS(fullVPDExample) - 2;
|
|
- buf = g_malloc0(dataLen);
|
|
-
|
|
- if ((fd = virCreateAnonymousFile(fullVPDExample, dataLen)) < 0)
|
|
- return -1;
|
|
-
|
|
- readBytes = virPCIVPDReadVPDBytes(fd, buf, dataLen, 0, &csum);
|
|
-
|
|
- if (readBytes != dataLen) {
|
|
- virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
- "The number of bytes read %zu is lower than expected %zu ",
|
|
- readBytes, dataLen);
|
|
- return -1;
|
|
- }
|
|
-
|
|
- if (csum) {
|
|
- virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
- "The sum of all VPD bytes up to and including the checksum byte"
|
|
- "is equal to zero: 0x%02x", csum);
|
|
- return -1;
|
|
- }
|
|
- return 0;
|
|
-}
|
|
-
|
|
static int
|
|
testVirPCIVPDParseVPDStringResource(const void *opaque G_GNUC_UNUSED)
|
|
{
|
|
@@ -1003,8 +964,6 @@ mymain(void)
|
|
if (virTestRun("Determining a field value format by a key ",
|
|
testPCIVPDGetFieldValueFormat, NULL) < 0)
|
|
ret = -1;
|
|
- if (virTestRun("Reading VPD bytes ", testVirPCIVPDReadVPDBytes, NULL) < 0)
|
|
- ret = -1;
|
|
if (virTestRun("Parsing VPD string resources ", testVirPCIVPDParseVPDStringResource, NULL) < 0)
|
|
ret = -1;
|
|
if (virTestRun("Parsing a VPD resource with a zero-length RW ",
|
|
--
|
|
2.43.0
|