26e17db3c8
- build: Bump minimum glib2 version to 2.66.0 (RHEL-77884) - qemuProcessHandleIOError: Refactor to extract 'priv' instead of 'driver' (RHEL-77884) - qemu: Handle quirks of 'device' field of BLOCK_IO_ERROR event in monitor code (RHEL-77884) - qemu: Rename 'diskAlias' to 'device' in qemu IO error event handling (RHEL-77884) - qemuProcessHandleIOError: Rename local variables (RHEL-77884) - qemuMonitorJSONHandleIOError: Do not munge 'reason' field of IO error event (RHEL-77884) - qemuProcessHandleIOError: Prefer lookup by node name (RHEL-77884) - qemuMonitorJSONHandleIOError: Propagate new 'qom-path' field (RHEL-77884) - virStorageSource: Add fields for storing last I/O error message (RHEL-77884) - qemuProcessHandleIOError: Populate I/O error reason to virStorageSource (RHEL-77884) - qemuProcessHandleIOError: Log IO errors in the VM log file (RHEL-77884) - libxlDomainGetMessages: Add existing flags to 'virCheckFlags' (RHEL-77884) - virDomainObjGetMessages: Refactor using GPtrArray (RHEL-77884) - virDomainGetMessages: Introduce VIR_DOMAIN_MESSAGE_IOERRORS (RHEL-77884) - include: libvirt-domain: Reword documentation for @reason of VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON (RHEL-77884) - include: libvirt-domain: Add 'message' @reason of VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON (RHEL-77884) - qemuSnapshotForEachQcow2: Don't initialize 'nrollback' (RHEL-73315) - qemu: process: Export qemuPrepareNVRAM for use in snapshot code (RHEL-73315) - qemu: snapshot: Ensure that NVRAM image exists when taking inactive internal snapshot (RHEL-73315) - qemuxmlconftest: Allow testing of the 'writable' flag for passed FDs for disks (RHEL-37519) - qemuxmlconftest: Add testing of FDs with 'writable' flag in 'disk-source-fd' (RHEL-37519) - qemu: domain: Initialize FD passthrough for a virStorageSource before using it (RHEL-37519) Resolves: RHEL-37519, RHEL-73315, RHEL-77884
70 lines
2.9 KiB
Diff
70 lines
2.9 KiB
Diff
From ebe771353b9511ec5850a1415b82399a53fa2c71 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <ebe771353b9511ec5850a1415b82399a53fa2c71.1738940191.git.jdenemar@redhat.com>
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
|
Date: Fri, 24 Jan 2025 16:26:54 +0100
|
|
Subject: [PATCH] include: libvirt-domain: Add 'message' @reason of
|
|
VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
In case when the hypervisor does report the reason for the I/O error as
|
|
an unstable string to display to users we can add a @reason possibility
|
|
for the I/O error event noting that the error is available.
|
|
|
|
Add 'message' as a reason enumeration value and document it
|
|
to instruct users to look at the logs or virDomainGetMessages().
|
|
|
|
The resulting event looks like:
|
|
|
|
event 'io-error' for domain 'cd': /dev/mapper/errdev0 (virtio-disk0) report due to message
|
|
|
|
Users then can look at the virDomainGetMessages() API:
|
|
|
|
I/O error: disk='vda', index='1', path='/dev/mapper/errdev0', timestamp='2025-01-28 15:47:52.776+0000', message='Input/output error'
|
|
|
|
Or in the VM log file:
|
|
|
|
2025-01-28 15:47:52.776+0000: IO error device='virtio-disk0' node-name='libvirt-1-storage' reason='Input/output error'
|
|
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
|
(cherry picked from commit 97c47333cbdc2531260f7b11b1fa9ba828878343)
|
|
|
|
https://issues.redhat.com/browse/RHEL-77884
|
|
---
|
|
include/libvirt/libvirt-domain.h | 4 ++++
|
|
src/qemu/qemu_process.c | 2 ++
|
|
2 files changed, 6 insertions(+)
|
|
|
|
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
|
|
index 1dc7b417c9..f026ce197c 100644
|
|
--- a/include/libvirt/libvirt-domain.h
|
|
+++ b/include/libvirt/libvirt-domain.h
|
|
@@ -4782,6 +4782,10 @@ typedef void (*virConnectDomainEventIOErrorCallback)(virConnectPtr conn,
|
|
* - "enospc": The I/O error is known to be caused by an ENOSPC condition in
|
|
* the host. Resizing the disk source to be larger will allow the
|
|
* guest to be resumed as if nothing happened.
|
|
+ * - "message": The hypervisor reported a string description of the
|
|
+ * I/O error. The errors are usually logged into the
|
|
+ * domain log file or the last instance of the error
|
|
+ * string can be queried via virDomainGetMessages().
|
|
*
|
|
* Since: 0.8.1
|
|
*/
|
|
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
|
|
index 409734d948..b9d69649ca 100644
|
|
--- a/src/qemu/qemu_process.c
|
|
+++ b/src/qemu/qemu_process.c
|
|
@@ -862,6 +862,8 @@ qemuProcessHandleIOError(qemuMonitor *mon G_GNUC_UNUSED,
|
|
|
|
if (nospace)
|
|
eventReason = "enospc";
|
|
+ else if (reason)
|
|
+ eventReason = "message";
|
|
|
|
ioErrorEvent = virDomainEventIOErrorNewFromObj(vm, eventPath, eventAlias, action);
|
|
ioErrorEvent2 = virDomainEventIOErrorReasonNewFromObj(vm, eventPath, eventAlias, action, eventReason);
|
|
--
|
|
2.48.1
|