9ea8eed2bd
- remote_driver: Restore special behavior of remoteDomainGetBlockIoTune() (RHEL-22800) - conf: Introduce dynamicMemslots attribute for virtio-mem (RHEL-15316) - qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_DYNAMIC_MEMSLOTS capability (RHEL-15316) - qemu_validate: Check capability for virtio-mem dynamicMemslots (RHEL-15316) - qemu_command: Generate cmd line for virtio-mem dynamicMemslots (RHEL-15316) - qemu_snapshot: fix detection if non-leaf snapshot isn't in active chain (RHEL-23212) - qemu_snapshot: create: refactor external snapshot detection (RHEL-22797) - qemu_snapshot: create: don't require disk-only flag for offline external snapshot (RHEL-22797) - remoteDispatchAuthPolkit: Fix lock ordering deadlock if client closes connection during auth (RHEL-20337) - util: virtportallocator: Add VIR_DEBUG statements for port allocations and release (RHEL-21543) - qemu: migration: Properly handle reservation of manually specified NBD port (RHEL-21543) - qemuMigrationDstStartNBDServer: Refactor cleanup (RHEL-21543) - virPCIVPDResourceIsValidTextValue: Adjust comment to reflect actual code (RHEL-22314) - util: pcivpd: Refactor virPCIVPDResourceIsValidTextValue (RHEL-22314) - virNodeDeviceCapVPDFormatCustom*: Escape unsanitized strings (RHEL-22314) - virNodeDeviceCapVPDFormat: Properly escape system-originated strings (RHEL-22314) - schema: nodedev: Adjust allowed characters in 'vpdFieldValueFormat' (RHEL-22314) - tests: Test the previously mishandled PCI VPD characters (RHEL-22314) - Don't overwrite error message from 'virXPathNodeSet' (RHEL-22314) - tests: virpcivpdtest: Remove 'testVirPCIVPDReadVPDBytes' case (RHEL-22314) - util: virpcivpd: Unexport 'virPCIVPDReadVPDBytes' (RHEL-22314) - util: pcivpd: Unexport virPCIVPDParseVPDLargeResourceFields (RHEL-22314) - tests: virpcivpd: Remove 'testVirPCIVPDParseVPDStringResource' case (RHEL-22314) - util: virpcivpd: Unexport 'virPCIVPDParseVPDLargeResourceString' (RHEL-22314) - virPCIVPDResourceGetKeywordPrefix: Fix logging (RHEL-22314) - util: virpcivpd: Remove return value from virPCIVPDResourceCustomUpsertValue (RHEL-22314) - conf: virNodeDeviceCapVPDParse*: Remove pointless NULL checks (RHEL-22314) - virpcivpdtest: testPCIVPDResourceBasic: Remove tests for uninitialized 'ro'/'rw' section (RHEL-22314) - util: virPCIVPDResourceUpdateKeyword: Remove impossible checks (RHEL-22314) - conf: node_device: Refactor 'virNodeDeviceCapVPDParseCustomFields' to fix error reporting (RHEL-22314) - virNodeDeviceCapVPDParseXML: Fix error reporting (RHEL-22314) - util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword (RHEL-22314) - virPCIDeviceHasVPD: Refactor "debug" messages (RHEL-22314) - virPCIDeviceGetVPD: Fix multiple error handling bugs (RHEL-22314) - virPCIDeviceGetVPD: Handle errors in callers (RHEL-22314) - virPCIVPDReadVPDBytes: Refactor error handling (RHEL-22314) - virPCIVPDParseVPDLargeResourceString: Properly report errors (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Merge logic conditions (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Remove impossible 'default' switch case (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Refactor processing of read data (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Refactor return logic (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Report proper errors (RHEL-22314) - virPCIVPDParse: Do reasonable error reporting (RHEL-22314) - virt-admin: Add warning when connection to default daemon fails (RHEL-23170) Resolves: RHEL-15316, RHEL-20337, RHEL-21543, RHEL-22314, RHEL-22797 Resolves: RHEL-22800, RHEL-23170, RHEL-23212
86 lines
3.6 KiB
Diff
86 lines
3.6 KiB
Diff
From 636dbbfd795583431523972a0057ede74d110a6e Mon Sep 17 00:00:00 2001
|
|
Message-ID: <636dbbfd795583431523972a0057ede74d110a6e.1707394627.git.jdenemar@redhat.com>
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
|
Date: Wed, 24 Jan 2024 17:13:51 +0100
|
|
Subject: [PATCH] virpcivpdtest: testPCIVPDResourceBasic: Remove tests for
|
|
uninitialized 'ro'/'rw' section
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
This is a synthetic case which tests the behaviour if the 'ro' or 'rw'
|
|
struct members are uninitialized, basically excercising only a pointless
|
|
programming-error NULL check in 'virPCIVPDResourceUpdateKeyword' as real
|
|
usage does always pass a proper pointer.
|
|
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
(cherry picked from commit e8f5edf556145cbe6bae53255ded3051d65f24f1)
|
|
|
|
https://issues.redhat.com/browse/RHEL-22314 [9.4.0]
|
|
---
|
|
tests/virpcivpdtest.c | 27 ---------------------------
|
|
1 file changed, 27 deletions(-)
|
|
|
|
diff --git a/tests/virpcivpdtest.c b/tests/virpcivpdtest.c
|
|
index 8a2f337e85..20545759d5 100644
|
|
--- a/tests/virpcivpdtest.c
|
|
+++ b/tests/virpcivpdtest.c
|
|
@@ -64,11 +64,6 @@ testPCIVPDResourceBasic(const void *data G_GNUC_UNUSED)
|
|
{.keyword = "SN", .value = "serial2", .actual = &ro->serial_number},
|
|
{.keyword = "serial_number", .value = "serial3", .actual = &ro->serial_number},
|
|
};
|
|
- const TestPCIVPDKeywordValue readWriteCases[] = {
|
|
- {.keyword = "YA", .value = "tag1", .actual = &ro->change_level},
|
|
- {.keyword = "YA", .value = "tag2", .actual = &ro->change_level},
|
|
- {.keyword = "asset_tag", .value = "tag3", .actual = &ro->change_level},
|
|
- };
|
|
const TestPCIVPDKeywordValue unsupportedFieldCases[] = {
|
|
{.keyword = "FG", .value = "42", .actual = NULL},
|
|
{.keyword = "LC", .value = "42", .actual = NULL},
|
|
@@ -77,7 +72,6 @@ testPCIVPDResourceBasic(const void *data G_GNUC_UNUSED)
|
|
{.keyword = "EX", .value = "42", .actual = NULL},
|
|
};
|
|
size_t numROCases = G_N_ELEMENTS(readOnlyCases);
|
|
- size_t numRWCases = G_N_ELEMENTS(readWriteCases);
|
|
size_t numUnsupportedCases = G_N_ELEMENTS(unsupportedFieldCases);
|
|
g_autoptr(virPCIVPDResource) res = g_new0(virPCIVPDResource, 1);
|
|
virPCIVPDResourceCustom *custom = NULL;
|
|
@@ -85,20 +79,6 @@ testPCIVPDResourceBasic(const void *data G_GNUC_UNUSED)
|
|
g_autofree char *val = g_strdup("testval");
|
|
res->name = g_steal_pointer(&val);
|
|
|
|
- /* RO has not been initialized - make sure updates fail. */
|
|
- for (i = 0; i < numROCases; ++i) {
|
|
- if (virPCIVPDResourceUpdateKeyword(res, true,
|
|
- readOnlyCases[i].keyword,
|
|
- readOnlyCases[i].value))
|
|
- return -1;
|
|
- }
|
|
- /* RW has not been initialized - make sure updates fail. */
|
|
- for (i = 0; i < numRWCases; ++i) {
|
|
- if (virPCIVPDResourceUpdateKeyword(res, false,
|
|
- readWriteCases[i].keyword,
|
|
- readWriteCases[i].value))
|
|
- return -1;
|
|
- }
|
|
/* Initialize RO */
|
|
res->ro = g_steal_pointer(&ro);
|
|
|
|
@@ -131,13 +111,6 @@ testPCIVPDResourceBasic(const void *data G_GNUC_UNUSED)
|
|
return -1;
|
|
}
|
|
|
|
- /* Check that RW updates fail if RW has not been initialized. */
|
|
- if (virPCIVPDResourceUpdateKeyword(res, false, "YA", "tag1"))
|
|
- return -1;
|
|
-
|
|
- if (virPCIVPDResourceUpdateKeyword(res, false, "asset_tag", "tag1"))
|
|
- return -1;
|
|
-
|
|
/* Initialize RW */
|
|
res->rw = g_steal_pointer(&rw);
|
|
if (!virPCIVPDResourceUpdateKeyword(res, false, "YA", "tag1")
|
|
--
|
|
2.43.0
|