9ea8eed2bd
- remote_driver: Restore special behavior of remoteDomainGetBlockIoTune() (RHEL-22800) - conf: Introduce dynamicMemslots attribute for virtio-mem (RHEL-15316) - qemu_capabilities: Add QEMU_CAPS_DEVICE_VIRTIO_MEM_PCI_DYNAMIC_MEMSLOTS capability (RHEL-15316) - qemu_validate: Check capability for virtio-mem dynamicMemslots (RHEL-15316) - qemu_command: Generate cmd line for virtio-mem dynamicMemslots (RHEL-15316) - qemu_snapshot: fix detection if non-leaf snapshot isn't in active chain (RHEL-23212) - qemu_snapshot: create: refactor external snapshot detection (RHEL-22797) - qemu_snapshot: create: don't require disk-only flag for offline external snapshot (RHEL-22797) - remoteDispatchAuthPolkit: Fix lock ordering deadlock if client closes connection during auth (RHEL-20337) - util: virtportallocator: Add VIR_DEBUG statements for port allocations and release (RHEL-21543) - qemu: migration: Properly handle reservation of manually specified NBD port (RHEL-21543) - qemuMigrationDstStartNBDServer: Refactor cleanup (RHEL-21543) - virPCIVPDResourceIsValidTextValue: Adjust comment to reflect actual code (RHEL-22314) - util: pcivpd: Refactor virPCIVPDResourceIsValidTextValue (RHEL-22314) - virNodeDeviceCapVPDFormatCustom*: Escape unsanitized strings (RHEL-22314) - virNodeDeviceCapVPDFormat: Properly escape system-originated strings (RHEL-22314) - schema: nodedev: Adjust allowed characters in 'vpdFieldValueFormat' (RHEL-22314) - tests: Test the previously mishandled PCI VPD characters (RHEL-22314) - Don't overwrite error message from 'virXPathNodeSet' (RHEL-22314) - tests: virpcivpdtest: Remove 'testVirPCIVPDReadVPDBytes' case (RHEL-22314) - util: virpcivpd: Unexport 'virPCIVPDReadVPDBytes' (RHEL-22314) - util: pcivpd: Unexport virPCIVPDParseVPDLargeResourceFields (RHEL-22314) - tests: virpcivpd: Remove 'testVirPCIVPDParseVPDStringResource' case (RHEL-22314) - util: virpcivpd: Unexport 'virPCIVPDParseVPDLargeResourceString' (RHEL-22314) - virPCIVPDResourceGetKeywordPrefix: Fix logging (RHEL-22314) - util: virpcivpd: Remove return value from virPCIVPDResourceCustomUpsertValue (RHEL-22314) - conf: virNodeDeviceCapVPDParse*: Remove pointless NULL checks (RHEL-22314) - virpcivpdtest: testPCIVPDResourceBasic: Remove tests for uninitialized 'ro'/'rw' section (RHEL-22314) - util: virPCIVPDResourceUpdateKeyword: Remove impossible checks (RHEL-22314) - conf: node_device: Refactor 'virNodeDeviceCapVPDParseCustomFields' to fix error reporting (RHEL-22314) - virNodeDeviceCapVPDParseXML: Fix error reporting (RHEL-22314) - util: virpcivpd: Remove return value from virPCIVPDResourceUpdateKeyword (RHEL-22314) - virPCIDeviceHasVPD: Refactor "debug" messages (RHEL-22314) - virPCIDeviceGetVPD: Fix multiple error handling bugs (RHEL-22314) - virPCIDeviceGetVPD: Handle errors in callers (RHEL-22314) - virPCIVPDReadVPDBytes: Refactor error handling (RHEL-22314) - virPCIVPDParseVPDLargeResourceString: Properly report errors (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Merge logic conditions (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Remove impossible 'default' switch case (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Refactor processing of read data (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Refactor return logic (RHEL-22314) - virPCIVPDParseVPDLargeResourceFields: Report proper errors (RHEL-22314) - virPCIVPDParse: Do reasonable error reporting (RHEL-22314) - virt-admin: Add warning when connection to default daemon fails (RHEL-23170) Resolves: RHEL-15316, RHEL-20337, RHEL-21543, RHEL-22314, RHEL-22797 Resolves: RHEL-22800, RHEL-23170, RHEL-23212
82 lines
2.8 KiB
Diff
82 lines
2.8 KiB
Diff
From 7c634eb7244604521b0f2a00f3a7e2e65a6a8399 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <7c634eb7244604521b0f2a00f3a7e2e65a6a8399.1707394627.git.jdenemar@redhat.com>
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
|
Date: Mon, 29 Jan 2024 17:55:06 +0100
|
|
Subject: [PATCH] tests: virpcivpd: Remove
|
|
'testVirPCIVPDParseVPDStringResource' case
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The test case excercises 'virPCIVPDParseVPDLargeResourceString' which is
|
|
also tested by other cases which parse the whole VPD block. Remove the
|
|
specific test case as it's not adding any additional value.
|
|
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
|
(cherry picked from commit 78e17cd550f0ee1f200557d496ef43724319c17e)
|
|
|
|
https://issues.redhat.com/browse/RHEL-22314 [9.4.0]
|
|
---
|
|
tests/virpcivpdtest.c | 38 --------------------------------------
|
|
1 file changed, 38 deletions(-)
|
|
|
|
diff --git a/tests/virpcivpdtest.c b/tests/virpcivpdtest.c
|
|
index aadd1b222b..fddb42f52c 100644
|
|
--- a/tests/virpcivpdtest.c
|
|
+++ b/tests/virpcivpdtest.c
|
|
@@ -429,42 +429,6 @@ testPCIVPDGetFieldValueFormat(const void *data G_GNUC_UNUSED)
|
|
'Y', 'E', 0x00, \
|
|
'R', 'W', 0x02, 0x00, 0x00
|
|
|
|
-static int
|
|
-testVirPCIVPDParseVPDStringResource(const void *opaque G_GNUC_UNUSED)
|
|
-{
|
|
- VIR_AUTOCLOSE fd = -1;
|
|
- uint8_t csum = 0;
|
|
- size_t dataLen = 0;
|
|
- bool result = false;
|
|
-
|
|
- g_autoptr(virPCIVPDResource) res = g_new0(virPCIVPDResource, 1);
|
|
- const char *expectedValue = "testname";
|
|
-
|
|
- const uint8_t stringResExample[] = {
|
|
- VPD_STRING_RESOURCE_EXAMPLE_DATA
|
|
- };
|
|
-
|
|
- dataLen = G_N_ELEMENTS(stringResExample);
|
|
- if ((fd = virCreateAnonymousFile(stringResExample, dataLen)) < 0)
|
|
- return -1;
|
|
-
|
|
- result = virPCIVPDParseVPDLargeResourceString(fd, 0, dataLen, &csum, res);
|
|
-
|
|
- if (!result) {
|
|
- virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
|
|
- "Could not parse the example resource.");
|
|
- return -1;
|
|
- }
|
|
-
|
|
- if (STRNEQ(expectedValue, res->name)) {
|
|
- virReportError(VIR_ERR_INTERNAL_ERROR,
|
|
- "Unexpected string resource value: %s, expected: %s",
|
|
- res->name, expectedValue);
|
|
- return -1;
|
|
- }
|
|
- return 0;
|
|
-}
|
|
-
|
|
static int
|
|
testVirPCIVPDValidateExampleReadOnlyFields(virPCIVPDResource *res)
|
|
{
|
|
@@ -964,8 +928,6 @@ mymain(void)
|
|
if (virTestRun("Determining a field value format by a key ",
|
|
testPCIVPDGetFieldValueFormat, NULL) < 0)
|
|
ret = -1;
|
|
- if (virTestRun("Parsing VPD string resources ", testVirPCIVPDParseVPDStringResource, NULL) < 0)
|
|
- ret = -1;
|
|
if (virTestRun("Parsing a VPD resource with a zero-length RW ",
|
|
testVirPCIVPDParseZeroLengthRW, NULL) < 0)
|
|
ret = -1;
|
|
--
|
|
2.43.0
|