05ff4ee618
- Add load average information type into virDomainGetGuestInfo (RHEL-88447) - qemu_agent: Add qemuAgentGetLoadAvg() (RHEL-88447) - qemu: Add support for VIR_DOMAIN_GUEST_INFO_LOAD (RHEL-88447) - virsh: Add support for VIR_DOMAIN_GUEST_INFO_LOAD (RHEL-88447) - qemu_capabilities: Fetch caps for virtio-mem-ccw too (RHEL-87532) - cpu_map: Add avx10* CPU features (RHEL-87796) - cpu_map: Add GraniteRapids-v2 CPU model (RHEL-87796) - cpu_map: Add sha512, sm3, and sm4 CPU features (RHEL-87796) - virsh: Introduce new hypervisor-cpu-models command (RHEL-11435) - qemu: remove nonsensical sanity check in processNetdevStreamDisconnectedEvent() (RHEL-80169) - qemu: make processNetDevStreamDisconnectedEvent() reusable (RHEL-80169) - qemu: respond to NETDEV_VHOST_USER_DISCONNECTED event (RHEL-80169) - qemu: put vhost-user code that's special for passt in a helper function (RHEL-80169) - qemu: make passt+vhostuser reconnect behave identically to passt+user (RHEL-80169) Resolves: RHEL-11435, RHEL-80169, RHEL-87532, RHEL-87796, RHEL-88447
57 lines
2.3 KiB
Diff
57 lines
2.3 KiB
Diff
From 13ff514007822c650ad0f3006882e2f85aab9b48 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <13ff514007822c650ad0f3006882e2f85aab9b48.1747908718.git.jdenemar@redhat.com>
|
|
From: Laine Stump <laine@redhat.com>
|
|
Date: Fri, 4 Apr 2025 16:48:23 -0400
|
|
Subject: [PATCH] qemu: remove nonsensical sanity check in
|
|
processNetdevStreamDisconnectedEvent()
|
|
|
|
By definition QEMU will never send a NETDEV_STREAM_DISCONNECTED event
|
|
if it doesn't support the reconnect option for a stream netdev. And
|
|
even if, by some comedy of errors, it did send
|
|
NETDEV_STREAM_DISCONNECTED in that case, our response to the event
|
|
doesn't request anything at all of QEMU (much less something that
|
|
would fail if QEMU didn't understand NETDEV_STREAM_DISCONNECTED) - it
|
|
just starts a new passt process to replace the one that has been
|
|
terminated, so we don't need to check the QEMU capabilities for
|
|
QEMU_CAPS_NETDEV_STREAM_RECONNECT.
|
|
|
|
Signed-off-by: Laine Stump <laine@redhat.com>
|
|
Tested-by: Stefano Brivio <sbrivio@redhat.com>
|
|
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
|
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
|
|
(cherry picked from commit 51a54dc1c4ecf37d60acee1cb94252e51c5ef627)
|
|
|
|
https://issues.redhat.com/browse/RHEL-80169
|
|
Signed-off-by: Laine Stump <laine@redhat.com>
|
|
---
|
|
src/qemu/qemu_driver.c | 7 -------
|
|
1 file changed, 7 deletions(-)
|
|
|
|
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
|
|
index 11dbbc1aab..89bb10756e 100644
|
|
--- a/src/qemu/qemu_driver.c
|
|
+++ b/src/qemu/qemu_driver.c
|
|
@@ -3623,7 +3623,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm,
|
|
{
|
|
virDomainDeviceDef dev;
|
|
virDomainNetDef *def;
|
|
- virQEMUCaps *qemuCaps = QEMU_DOMAIN_PRIVATE(vm)->qemuCaps;
|
|
const char *devAlias = STRSKIP(netdevId, "host");
|
|
|
|
/* The event sends us the "netdev-id", but we don't store the
|
|
@@ -3669,12 +3668,6 @@ processNetdevStreamDisconnectedEvent(virDomainObj *vm,
|
|
goto endjob;
|
|
}
|
|
|
|
- if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_NETDEV_STREAM_RECONNECT)) {
|
|
- VIR_WARN("ignore NETDEV_STREAM_DISCONNECTED event for passt network device %s in domain %s - QEMU binary does not support reconnect",
|
|
- def->info.alias, vm->def->name);
|
|
- goto endjob;
|
|
- }
|
|
-
|
|
/* handle the event - restart the passt process with its original
|
|
* parameters
|
|
*/
|
|
--
|
|
2.49.0
|