8026296455
- util: introduce object for holding a system inhibitor lock (RHEL-83064) - src: convert drivers over to new virInhibitor APIs (RHEL-83064) - rpc: remove logind support for virNetDaemon (RHEL-83064) - util: fix off-by-1 in inhibitor constants (RHEL-83064) - util: don't attempt to acquire logind inhibitor if not requested (RHEL-83064) - network: Free inhibitor in networkStateCleanup() (RHEL-83064) - conf: introduce support for multiple ACPI tables (RHEL-81041) - src: validate permitted ACPI table types in libxl/qemu drivers (RHEL-81041) - src: introduce 'raw' and 'rawset' ACPI table types (RHEL-81041) - qemu: support 'raw' ACPI table type (RHEL-81041) - libxl: support 'rawset' ACPI table type (RHEL-81041) - conf: support MSDM ACPI table type (RHEL-81041) - qemu: support MSDM ACPI table type (RHEL-81041) - qemuxmlconftest: Include shared memory 'net-vhostuser' test cases (RHEL-84133) - qemuValidateDomainDeviceDefNetwork: Require shared memory for all vhost-user interfaces (RHEL-84133) - qemu: process: Remove un-updated 'qemuProcessStartWarnShmem' (RHEL-84133) Resolves: RHEL-81041, RHEL-83064, RHEL-84133
45 lines
1.8 KiB
Diff
45 lines
1.8 KiB
Diff
From 2ea12b6f6eed044dd7100ed19565319227f7384f Mon Sep 17 00:00:00 2001
|
|
Message-ID: <2ea12b6f6eed044dd7100ed19565319227f7384f.1742990721.git.jdenemar@redhat.com>
|
|
From: Michal Privoznik <mprivozn@redhat.com>
|
|
Date: Thu, 13 Mar 2025 13:01:19 +0100
|
|
Subject: [PATCH] network: Free inhibitor in networkStateCleanup()
|
|
|
|
The shutdown inhibitor is created in networkStateInitialize() but
|
|
corresponding call to virInhibitorFree() is missing in
|
|
networkStateCleanup() leading to a memleak:
|
|
|
|
116 (72 direct, 44 indirect) bytes in 1 blocks are definitely lost in loss record 1,769 of 1,998
|
|
at 0x484CEF3: calloc (vg_replace_malloc.c:1675)
|
|
by 0x4F0E7A9: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.8000.5)
|
|
by 0x4993B9B: virInhibitorNew (virinhibitor.c:152)
|
|
by 0x5279394: networkStateInitialize (bridge_driver.c:654)
|
|
by 0x4CC74DC: virStateInitialize (libvirt.c:665)
|
|
by 0x15B719: daemonRunStateInit (remote_daemon.c:613)
|
|
by 0x49F2B44: virThreadHelper (virthread.c:256)
|
|
by 0x5356662: start_thread (in /usr/lib64/libc.so.6)
|
|
by 0x53D7DA3: clone (in /usr/lib64/libc.so.6)
|
|
|
|
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
|
|
(cherry picked from commit 8701ba4feb528109da8b72fa48a8ada50a235807)
|
|
Resolves: https://issues.redhat.com/browse/RHEL-83064
|
|
---
|
|
src/network/bridge_driver.c | 2 ++
|
|
1 file changed, 2 insertions(+)
|
|
|
|
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
|
|
index ce793c12ef..adcff6f34f 100644
|
|
--- a/src/network/bridge_driver.c
|
|
+++ b/src/network/bridge_driver.c
|
|
@@ -802,6 +802,8 @@ networkStateCleanup(void)
|
|
network_driver->lockFD);
|
|
}
|
|
|
|
+ virInhibitorFree(network_driver->inhibitor);
|
|
+
|
|
virObjectUnref(network_driver->config);
|
|
virObjectUnref(network_driver->dnsmasqCaps);
|
|
|
|
--
|
|
2.49.0
|