- esxConnectListAllDomains: Don't propagate failure to lookup a single domain (RHEL-80606) - conf: parse interface/source/@dev for all interface types (with backend type='passt') (RHEL-82539) - libvirt-host: Clarify/fix description of the CPU frequency field (RHEL-86197) - virNodeGetInfo: Improve description of the case when fake data is reported (RHEL-86197) - manpages: virsh: Use disclaimer from 'virNodeGetInfo()' for 'virsh nodeinfo' (RHEL-86197) - esx: Accept empty "path" URI component same way as "/" (RHEL-86459) - qemu: Rename outgoingMigration parameter in various TPM functions (RHEL-86800) - qemu: Properly propagate migration state to TPM cleanup code (RHEL-86800) - qemuDomainBlockCopyCommon: Don't revoke access to file twice on failure (RHEL-7357) - qemuxmlconftest: Drop s390-default-cpu-...ccw-virtio-2.7 test cases (RHEL-72976) - tests: add capabilities for QEMU 10.0.0 on s390x (RHEL-72976) - qemu: Do NOT autoadd NUMA node for s390 (RHEL-72976) - qemu_command: Use qemuBuildVirtioDevProps() to build cmd line for virtio-mem and virtio-pmem (RHEL-72976) - qemuxmlconftest: Introduce memory-hotplug-virtio-mem-pci-s390x.xml (RHEL-72976) - qemu_caps: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW (RHEL-72976) - qemu: Validate virtio-mem-ccw (RHEL-72976) - qemu: Allow virtio-mem on CCW (RHEL-72976) - qemuxmlconftest: Introduce memory-hotplug-virtio-mem-ccw-s390x.xml (RHEL-72976) - qemu_domain_address: fix CCW virtio-mem hotplug (RHEL-72976) Resolves: RHEL-72976, RHEL-7357, RHEL-80606, RHEL-82539, RHEL-86197 Resolves: RHEL-86459, RHEL-86800
229 lines
9.7 KiB
Diff
229 lines
9.7 KiB
Diff
From 800b0cb9c899ff14ddfb1b8528048a780a4a5949 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <800b0cb9c899ff14ddfb1b8528048a780a4a5949.1744876588.git.jdenemar@redhat.com>
|
|
From: Michal Privoznik <mprivozn@redhat.com>
|
|
Date: Wed, 15 Jan 2025 10:45:31 +0100
|
|
Subject: [PATCH] qemuxmlconftest: Introduce
|
|
memory-hotplug-virtio-mem-pci-s390x.xml
|
|
|
|
As of v9.2.0-1413-gd77ae821e8 QEMU supports virtio-mem-pci on
|
|
s390 too. Let's add a test case for that.
|
|
|
|
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
|
|
(cherry picked from commit 621373d8a850c3882f6b62777f549285a5c0ab97)
|
|
Resolves: https://issues.redhat.com/browse/RHEL-72976
|
|
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
|
|
---
|
|
...lug-virtio-mem-pci-s390x.s390x-latest.args | 41 +++++++++++
|
|
...plug-virtio-mem-pci-s390x.s390x-latest.xml | 71 +++++++++++++++++++
|
|
.../memory-hotplug-virtio-mem-pci-s390x.xml | 59 +++++++++++++++
|
|
tests/qemuxmlconftest.c | 1 +
|
|
4 files changed, 172 insertions(+)
|
|
create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.args
|
|
create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.xml
|
|
create mode 100644 tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml
|
|
|
|
diff --git a/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.args b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.args
|
|
new file mode 100644
|
|
index 0000000000..9704d7d5e9
|
|
--- /dev/null
|
|
+++ b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.args
|
|
@@ -0,0 +1,41 @@
|
|
+LC_ALL=C \
|
|
+PATH=/bin \
|
|
+HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1 \
|
|
+USER=test \
|
|
+LOGNAME=test \
|
|
+XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.local/share \
|
|
+XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.cache \
|
|
+XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \
|
|
+/usr/bin/qemu-system-s390x \
|
|
+-name guest=QEMUGuest1,debug-threads=on \
|
|
+-S \
|
|
+-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \
|
|
+-machine s390-ccw-virtio,usb=off,dump-guest-core=off \
|
|
+-accel kvm \
|
|
+-cpu gen16a-base \
|
|
+-m size=2095104k,maxmem=1099511627776k \
|
|
+-overcommit mem-lock=off \
|
|
+-smp 2,sockets=2,cores=1,threads=1 \
|
|
+-object '{"qom-type":"memory-backend-ram","id":"ram-node0","size":2145386496}' \
|
|
+-numa node,nodeid=0,cpus=0-1,memdev=ram-node0 \
|
|
+-uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \
|
|
+-display none \
|
|
+-no-user-config \
|
|
+-nodefaults \
|
|
+-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \
|
|
+-mon chardev=charmonitor,id=monitor,mode=control \
|
|
+-rtc base=utc \
|
|
+-no-shutdown \
|
|
+-boot strict=on \
|
|
+-device '{"driver":"zpci","uid":1,"fid":0,"target":"pci.1","id":"zpci1"}' \
|
|
+-device '{"driver":"pci-bridge","chassis_nr":1,"id":"pci.1","bus":"pci.0","addr":"0x1"}' \
|
|
+-object '{"qom-type":"memory-backend-ram","id":"memvirtiomem0","reserve":false,"size":1073741824}' \
|
|
+-device '{"driver":"virtio-mem-pci","node":0,"block-size":2097152,"requested-size":536870912,"memdev":"memvirtiomem0","id":"virtiomem0","bus":"pci.0","addr":"0x2"}' \
|
|
+-object '{"qom-type":"memory-backend-file","id":"memvirtiomem1","mem-path":"/dev/hugepages2M/libvirt/qemu/-1-QEMUGuest1","reserve":false,"size":2147483648,"host-nodes":[1,2,3],"policy":"bind"}' \
|
|
+-device '{"driver":"virtio-mem-pci","node":0,"block-size":2097152,"requested-size":1073741824,"memdev":"memvirtiomem1","prealloc":true,"memaddr":5637144576,"dynamic-memslots":true,"id":"virtiomem1","bus":"pci.1","addr":"0x1"}' \
|
|
+-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-1-storage","read-only":false}' \
|
|
+-device '{"driver":"virtio-blk-ccw","devno":"fe.0.0000","drive":"libvirt-1-storage","id":"virtio-disk0","bootindex":1}' \
|
|
+-audiodev '{"id":"audio1","driver":"none"}' \
|
|
+-device '{"driver":"virtio-balloon-ccw","id":"balloon0","devno":"fe.0.0001"}' \
|
|
+-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \
|
|
+-msg timestamp=on
|
|
diff --git a/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.xml b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.xml
|
|
new file mode 100644
|
|
index 0000000000..336c6e5aac
|
|
--- /dev/null
|
|
+++ b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.s390x-latest.xml
|
|
@@ -0,0 +1,71 @@
|
|
+<domain type='kvm'>
|
|
+ <name>QEMUGuest1</name>
|
|
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
|
+ <maxMemory unit='KiB'>1099511627776</maxMemory>
|
|
+ <memory unit='KiB'>8388608</memory>
|
|
+ <currentMemory unit='KiB'>8388608</currentMemory>
|
|
+ <vcpu placement='static' cpuset='0-1'>2</vcpu>
|
|
+ <os>
|
|
+ <type arch='s390x' machine='s390-ccw-virtio'>hvm</type>
|
|
+ <boot dev='hd'/>
|
|
+ </os>
|
|
+ <cpu mode='custom' match='exact' check='none'>
|
|
+ <model fallback='forbid'>gen16a-base</model>
|
|
+ <numa>
|
|
+ <cell id='0' cpus='0-1' memory='2095104' unit='KiB'/>
|
|
+ </numa>
|
|
+ </cpu>
|
|
+ <clock offset='utc'/>
|
|
+ <on_poweroff>destroy</on_poweroff>
|
|
+ <on_reboot>restart</on_reboot>
|
|
+ <on_crash>destroy</on_crash>
|
|
+ <devices>
|
|
+ <emulator>/usr/bin/qemu-system-s390x</emulator>
|
|
+ <disk type='block' device='disk'>
|
|
+ <driver name='qemu' type='raw'/>
|
|
+ <source dev='/dev/HostVG/QEMUGuest1'/>
|
|
+ <target dev='hda' bus='virtio'/>
|
|
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
|
|
+ </disk>
|
|
+ <controller type='pci' index='0' model='pci-root'/>
|
|
+ <controller type='pci' index='1' model='pci-bridge'>
|
|
+ <model name='pci-bridge'/>
|
|
+ <target chassisNr='1'/>
|
|
+ <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'>
|
|
+ <zpci uid='0x0001' fid='0x00000000'/>
|
|
+ </address>
|
|
+ </controller>
|
|
+ <audio id='1' type='none'/>
|
|
+ <memballoon model='virtio'>
|
|
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0001'/>
|
|
+ </memballoon>
|
|
+ <panic model='s390'/>
|
|
+ <memory model='virtio-mem'>
|
|
+ <target>
|
|
+ <size unit='KiB'>1048576</size>
|
|
+ <node>0</node>
|
|
+ <block unit='KiB'>2048</block>
|
|
+ <requested unit='KiB'>524288</requested>
|
|
+ </target>
|
|
+ <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'>
|
|
+ <zpci uid='0x0002' fid='0x00000001'/>
|
|
+ </address>
|
|
+ </memory>
|
|
+ <memory model='virtio-mem'>
|
|
+ <source>
|
|
+ <nodemask>1-3</nodemask>
|
|
+ <pagesize unit='KiB'>2048</pagesize>
|
|
+ </source>
|
|
+ <target dynamicMemslots='yes'>
|
|
+ <size unit='KiB'>2097152</size>
|
|
+ <node>0</node>
|
|
+ <block unit='KiB'>2048</block>
|
|
+ <requested unit='KiB'>1048576</requested>
|
|
+ <address base='0x150000000'/>
|
|
+ </target>
|
|
+ <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'>
|
|
+ <zpci uid='0x0003' fid='0x00000002'/>
|
|
+ </address>
|
|
+ </memory>
|
|
+ </devices>
|
|
+</domain>
|
|
diff --git a/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml
|
|
new file mode 100644
|
|
index 0000000000..747877042a
|
|
--- /dev/null
|
|
+++ b/tests/qemuxmlconfdata/memory-hotplug-virtio-mem-pci-s390x.xml
|
|
@@ -0,0 +1,59 @@
|
|
+<domain type='kvm'>
|
|
+ <name>QEMUGuest1</name>
|
|
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
|
|
+ <maxMemory unit='KiB'>1099511627776</maxMemory>
|
|
+ <memory unit='KiB'>8388608</memory>
|
|
+ <currentMemory unit='KiB'>8388608</currentMemory>
|
|
+ <vcpu placement='static' cpuset='0-1'>2</vcpu>
|
|
+ <os>
|
|
+ <type arch='s390x' machine='s390-ccw-virtio'>hvm</type>
|
|
+ <boot dev='hd'/>
|
|
+ </os>
|
|
+ <cpu mode='custom' match='exact' check='none'>
|
|
+ <model fallback='forbid'>gen16a-base</model>
|
|
+ <numa>
|
|
+ <cell id='0' cpus='0-1' memory='2095104' unit='KiB'/>
|
|
+ </numa>
|
|
+ </cpu>
|
|
+ <clock offset='utc'/>
|
|
+ <on_poweroff>destroy</on_poweroff>
|
|
+ <on_reboot>restart</on_reboot>
|
|
+ <on_crash>destroy</on_crash>
|
|
+ <devices>
|
|
+ <emulator>/usr/bin/qemu-system-s390x</emulator>
|
|
+ <disk type='block' device='disk'>
|
|
+ <driver name='qemu' type='raw'/>
|
|
+ <source dev='/dev/HostVG/QEMUGuest1'/>
|
|
+ <target dev='hda' bus='virtio'/>
|
|
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0000'/>
|
|
+ </disk>
|
|
+ <controller type='pci' index='0' model='pci-root'/>
|
|
+ <audio id='1' type='none'/>
|
|
+ <memballoon model='virtio'>
|
|
+ <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x0001'/>
|
|
+ </memballoon>
|
|
+ <memory model='virtio-mem'>
|
|
+ <target>
|
|
+ <size unit='KiB'>1048576</size>
|
|
+ <node>0</node>
|
|
+ <block unit='KiB'>2048</block>
|
|
+ <requested unit='KiB'>524288</requested>
|
|
+ </target>
|
|
+ <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
|
|
+ </memory>
|
|
+ <memory model='virtio-mem'>
|
|
+ <source>
|
|
+ <nodemask>1-3</nodemask>
|
|
+ <pagesize unit='KiB'>2048</pagesize>
|
|
+ </source>
|
|
+ <target dynamicMemslots='yes'>
|
|
+ <size unit='KiB'>2097152</size>
|
|
+ <node>0</node>
|
|
+ <block unit='KiB'>2048</block>
|
|
+ <requested unit='KiB'>1048576</requested>
|
|
+ <address base='0x150000000'/>
|
|
+ </target>
|
|
+ <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/>
|
|
+ </memory>
|
|
+ </devices>
|
|
+</domain>
|
|
diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c
|
|
index 00a7677ea7..14f159b833 100644
|
|
--- a/tests/qemuxmlconftest.c
|
|
+++ b/tests/qemuxmlconftest.c
|
|
@@ -2715,6 +2715,7 @@ mymain(void)
|
|
* virDomainMemoryDefCheckConflict() works for NVDIMMs which are special
|
|
* than other memory devices because of how they handle <labelsize/> */
|
|
DO_TEST_CAPS_LATEST("memory-hotplug-nvdimm-overlap");
|
|
+ DO_TEST_CAPS_ARCH_LATEST("memory-hotplug-virtio-mem-pci-s390x", "s390x");
|
|
|
|
DO_TEST_CAPS_ARCH_LATEST("machine-aeskeywrap-on-caps", "s390x");
|
|
DO_TEST_CAPS_ARCH_LATEST("machine-aeskeywrap-on-cap", "s390x");
|
|
--
|
|
2.49.0
|