ef809b76a6
- esxConnectListAllDomains: Don't propagate failure to lookup a single domain (RHEL-80606) - conf: parse interface/source/@dev for all interface types (with backend type='passt') (RHEL-82539) - libvirt-host: Clarify/fix description of the CPU frequency field (RHEL-86197) - virNodeGetInfo: Improve description of the case when fake data is reported (RHEL-86197) - manpages: virsh: Use disclaimer from 'virNodeGetInfo()' for 'virsh nodeinfo' (RHEL-86197) - esx: Accept empty "path" URI component same way as "/" (RHEL-86459) - qemu: Rename outgoingMigration parameter in various TPM functions (RHEL-86800) - qemu: Properly propagate migration state to TPM cleanup code (RHEL-86800) - qemuDomainBlockCopyCommon: Don't revoke access to file twice on failure (RHEL-7357) - qemuxmlconftest: Drop s390-default-cpu-...ccw-virtio-2.7 test cases (RHEL-72976) - tests: add capabilities for QEMU 10.0.0 on s390x (RHEL-72976) - qemu: Do NOT autoadd NUMA node for s390 (RHEL-72976) - qemu_command: Use qemuBuildVirtioDevProps() to build cmd line for virtio-mem and virtio-pmem (RHEL-72976) - qemuxmlconftest: Introduce memory-hotplug-virtio-mem-pci-s390x.xml (RHEL-72976) - qemu_caps: Introduce QEMU_CAPS_DEVICE_VIRTIO_MEM_CCW (RHEL-72976) - qemu: Validate virtio-mem-ccw (RHEL-72976) - qemu: Allow virtio-mem on CCW (RHEL-72976) - qemuxmlconftest: Introduce memory-hotplug-virtio-mem-ccw-s390x.xml (RHEL-72976) - qemu_domain_address: fix CCW virtio-mem hotplug (RHEL-72976) Resolves: RHEL-72976, RHEL-7357, RHEL-80606, RHEL-82539, RHEL-86197 Resolves: RHEL-86459, RHEL-86800
50 lines
1.9 KiB
Diff
50 lines
1.9 KiB
Diff
From e9899b64816f8086038098b44690df076d93d8d8 Mon Sep 17 00:00:00 2001
|
|
Message-ID: <e9899b64816f8086038098b44690df076d93d8d8.1744876588.git.jdenemar@redhat.com>
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
|
Date: Tue, 8 Apr 2025 16:25:37 +0200
|
|
Subject: [PATCH] esx: Accept empty "path" URI component same way as "/"
|
|
|
|
When connecting to "esx://" URI there's code which prints a warning that
|
|
the path is not "empty". The check validates that "uri->path" is "/".
|
|
|
|
In case when the user uses URI such as:
|
|
|
|
esx://hostname
|
|
|
|
the warning is printed as well. Since there is no effective difference
|
|
betweeen the two allow empty strings as well.
|
|
|
|
Resolves: https://issues.redhat.com/browse/RHEL-86459
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
|
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
|
|
(cherry picked from commit 59f40ba67cc7d0a3f8eeb601c2f3c84def24a361)
|
|
---
|
|
src/esx/esx_driver.c | 5 ++++-
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c
|
|
index 6ae4ef9658..512ca6c028 100644
|
|
--- a/src/esx/esx_driver.c
|
|
+++ b/src/esx/esx_driver.c
|
|
@@ -687,7 +687,9 @@ esxConnectToVCenter(esxPrivate *priv,
|
|
g_autofree char *url = NULL;
|
|
|
|
if (!hostSystemIPAddress &&
|
|
- (!priv->parsedUri->path || STREQ(priv->parsedUri->path, "/"))) {
|
|
+ (!priv->parsedUri->path ||
|
|
+ STREQ(priv->parsedUri->path, "") ||
|
|
+ STREQ(priv->parsedUri->path, "/"))) {
|
|
virReportError(VIR_ERR_INVALID_ARG, "%s",
|
|
_("Path has to specify the datacenter and compute resource"));
|
|
return -1;
|
|
@@ -799,6 +801,7 @@ esxConnectOpen(virConnectPtr conn, virConnectAuthPtr auth,
|
|
virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR);
|
|
|
|
if (STRCASENEQ(conn->uri->scheme, "vpx") &&
|
|
+ STRNEQ(conn->uri->path, "") &&
|
|
STRNEQ(conn->uri->path, "/")) {
|
|
VIR_WARN("Ignoring unexpected path '%s' for non-vpx scheme '%s'",
|
|
conn->uri->path, conn->uri->scheme);
|
|
--
|
|
2.49.0
|