From 97d7066d53be18a9638d28217e2a4216fa422a53 Mon Sep 17 00:00:00 2001 Message-Id: <97d7066d53be18a9638d28217e2a4216fa422a53@dist-git> From: Michal Privoznik Date: Fri, 21 Feb 2020 14:32:11 +0100 Subject: [PATCH] virDomainNetDefClear: Free @persistent name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The persistent alias name @persistent is allocated in virDomainNetDefParseXML() but never freed. ==119642== 22 bytes in 2 blocks are definitely lost in loss record 178 of 671 ==119642== at 0x483579F: malloc (vg_replace_malloc.c:309) ==119642== by 0x58F89F1: xmlStrndup (in /usr/lib64/libxml2.so.2.9.9) ==119642== by 0x4BA3B74: virXMLPropString (virxml.c:520) ==119642== by 0x4BDB0C5: virDomainNetDefParseXML (domain_conf.c:11876) ==119642== by 0x4BF9EF4: virDomainDefParseXML (domain_conf.c:21196) ==119642== by 0x4BFCD5B: virDomainDefParseNode (domain_conf.c:21943) ==119642== by 0x4BFCC36: virDomainDefParse (domain_conf.c:21901) ==119642== by 0x4BFCCCB: virDomainDefParseFile (domain_conf.c:21924) ==119642== by 0x114A9D: testCompareXMLToArgv (qemuxml2argvtest.c:452) ==119642== by 0x13894F: virTestRun (testutils.c:143) ==119642== by 0x11F46E: mymain (qemuxml2argvtest.c:1316) ==119642== by 0x13A60E: virTestMain (testutils.c:839 Fixes: fb0509d06ac57434c2edbd81ee63deb32a0e598a Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko (cherry picked from commit 2ab278ec758b09398ea335626a41b453cdda6da7) Signed-off-by: Ján Tomko https://bugzilla.redhat.com/show_bug.cgi?id=1805742 Message-Id: Reviewed-by: Jiri Denemark --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 5c11f49463..8a5f14d6cb 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -2439,6 +2439,7 @@ virDomainNetDefClear(virDomainNetDefPtr def) VIR_FREE(def->backend.tap); VIR_FREE(def->backend.vhost); + VIR_FREE(def->teaming.persistent); VIR_FREE(def->virtPortProfile); VIR_FREE(def->script); VIR_FREE(def->domain_name); -- 2.25.1