From 15b1f63574db2100d433d283a975928f83bb0ecb Mon Sep 17 00:00:00 2001 Message-Id: <15b1f63574db2100d433d283a975928f83bb0ecb@dist-git> From: Laine Stump Date: Fri, 15 Jan 2021 22:51:44 -0500 Subject: [PATCH] util: fix typo in VIR_MOCK_WRAP_RET_ARGS() When virfirewalltest.c was first written in commit 3a0ca7de51 (March 2013), a conditional accidentally tested for "ipv4" instead of "ipv6". Since the file ended up only testing ipv4 rules, this has never made any difference in practice, but I'm making some other changes in this file and just couldn't let it stand :-) https://bugzilla.redhat.com/1607929 Signed-off-by: Laine Stump Reviewed-by: Daniel Henrique Barboza (cherry picked from commit 28a3deddddfe102b37f2e373bf4581c2ce8d2050) Message-Id: <20210116035151.1066734-2-laine@redhat.com> Reviewed-by: Jiri Denemark --- tests/virfirewalltest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index c4827918c3..8aba127610 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -129,7 +129,7 @@ VIR_MOCK_WRAP_RET_ARGS(dbus_connection_send_with_reply_and_block, if (fwBuf) { if (STREQ(type, "ipv4")) virBufferAddLit(fwBuf, IPTABLES_PATH); - else if (STREQ(type, "ipv4")) + else if (STREQ(type, "ipv6")) virBufferAddLit(fwBuf, IP6TABLES_PATH); else virBufferAddLit(fwBuf, EBTABLES_PATH); -- 2.30.0