From 132d30089ba007c53098f4b381dfd38db07ad1a0 Mon Sep 17 00:00:00 2001 Message-ID: <132d30089ba007c53098f4b381dfd38db07ad1a0.1763747165.git.jdenemar@redhat.com> From: Jiri Denemark Date: Fri, 24 Oct 2025 15:36:18 +0200 Subject: [PATCH] qemu_process: Always fix CPUs on reconnect MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We fix CPUs (i.e., remove ignored CPU features) only when libvirt/QEMU combo used to start the domain is very old and doesn't support query-cpu-model-expansion, in which case the CPU definition may contain features that are unknown to QEMU. But even if both libvirt and QEMU are new enough, we still want to remove features that do nothing to minimize confusion or to avoid false migration issues. Signed-off-by: Jiri Denemark Reviewed-by: Ján Tomko (cherry picked from commit c15ae99dab903004b82f8447f44df09973696f72) https://issues.redhat.com/browse/RHEL-126096 Signed-off-by: Jiri Denemark --- src/qemu/qemu_process.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 7c16390e8f..561c04f879 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -9447,12 +9447,7 @@ qemuProcessRefreshCPU(virQEMUDriver *driver, if (qemuProcessUpdateCPU(vm, VIR_ASYNC_JOB_NONE) < 0) return -1; - } else if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION)) { - /* We only try to fix CPUs when the libvirt/QEMU combo used to start - * the domain did not know about query-cpu-model-expansion in which - * case the host-model is known to not contain features which QEMU - * doesn't know about. - */ + } else { qemuDomainFixupCPUs(vm, priv->origCPU); } -- 2.51.1