66 lines
2.7 KiB
Diff
66 lines
2.7 KiB
Diff
|
From 2069251b1f50e1aaec566909478f1443ccfe32e6 Mon Sep 17 00:00:00 2001
|
||
|
|
Message-Id: <2069251b1f50e1aaec566909478f1443ccfe32e6@dist-git>
|
||
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
||
|
|
Date: Tue, 21 Jul 2020 13:56:22 +0200
|
||
|
|
Subject: [PATCH] qemu: blockjob: Actually delete temporary bitmap on failed
|
||
|
|
active commit
|
||
|
|
|
||
|
|
Commit 20a7abc2d2d tried to delete the possibly leftover bitmap but
|
||
|
|
neglected to call the actual monitor to do so.
|
||
|
|
|
||
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
||
|
|
Reviewed-by: Eric Blake <eblake@redhat.com>
|
||
|
|
(cherry picked from commit 378e4fbc795c607485799cbd060f34483f580544)
|
||
|
|
|
||
|
|
rhel-8.3: https://bugzilla.redhat.com/show_bug.cgi?id=1857779
|
||
|
|
rhel-av-8.2.1: not cloned yet
|
||
|
|
Message-Id: <add765f8f49b70dbfe1c2adf7e63e6e21b480c6d.1595332476.git.pkrempa@redhat.com>
|
||
|
|
|
||
|
|
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
|
||
|
|
---
|
||
|
|
src/qemu/qemu_blockjob.c | 13 +++++++++++--
|
||
|
|
1 file changed, 11 insertions(+), 2 deletions(-)
|
||
|
|
|
||
|
|
diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
|
||
|
|
index 7e2df1445d..486fca31f3 100644
|
||
|
|
--- a/src/qemu/qemu_blockjob.c
|
||
|
|
+++ b/src/qemu/qemu_blockjob.c
|
||
|
|
@@ -1378,8 +1378,10 @@ qemuBlockJobProcessEventConcludedCopyAbort(virQEMUDriverPtr driver,
|
||
|
|
static void
|
||
|
|
qemuBlockJobProcessEventFailedActiveCommit(virQEMUDriverPtr driver,
|
||
|
|
virDomainObjPtr vm,
|
||
|
|
- qemuBlockJobDataPtr job)
|
||
|
|
+ qemuBlockJobDataPtr job,
|
||
|
|
+ qemuDomainAsyncJob asyncJob)
|
||
|
|
{
|
||
|
|
+ qemuDomainObjPrivatePtr priv = vm->privateData;
|
||
|
|
g_autoptr(virJSONValue) actions = virJSONValueNewArray();
|
||
|
|
virDomainDiskDefPtr disk = job->disk;
|
||
|
|
|
||
|
|
@@ -1391,6 +1393,13 @@ qemuBlockJobProcessEventFailedActiveCommit(virQEMUDriverPtr driver,
|
||
|
|
ignore_value(qemuMonitorTransactionBitmapRemove(actions, disk->mirror->nodeformat,
|
||
|
|
"libvirt-tmp-activewrite"));
|
||
|
|
|
||
|
|
+ if (qemuDomainObjEnterMonitorAsync(priv->driver, vm, asyncJob) < 0)
|
||
|
|
+ return;
|
||
|
|
+
|
||
|
|
+ qemuMonitorTransaction(priv->mon, &actions);
|
||
|
|
+
|
||
|
|
+ if (qemuDomainObjExitMonitor(priv->driver, vm) < 0)
|
||
|
|
+ return;
|
||
|
|
|
||
|
|
/* Ideally, we would make the backing chain read only again (yes, SELinux
|
||
|
|
* can do that using different labels). But that is not implemented yet and
|
||
|
|
@@ -1515,7 +1524,7 @@ qemuBlockJobEventProcessConcludedTransition(qemuBlockJobDataPtr job,
|
||
|
|
if (success) {
|
||
|
|
qemuBlockJobProcessEventCompletedActiveCommit(driver, vm, job, asyncJob);
|
||
|
|
} else {
|
||
|
|
- qemuBlockJobProcessEventFailedActiveCommit(driver, vm, job);
|
||
|
|
+ qemuBlockJobProcessEventFailedActiveCommit(driver, vm, job, asyncJob);
|
||
|
|
}
|
||
|
|
break;
|
||
|
|
|
||
|
|
--
|
||
|
|
2.27.0
|
||
|
|
|