43 lines
1.7 KiB
Diff
43 lines
1.7 KiB
Diff
|
From 60d5a8463c380b005f16698bca7b38c11b122e03 Mon Sep 17 00:00:00 2001
|
||
|
|
Message-Id: <60d5a8463c380b005f16698bca7b38c11b122e03@dist-git>
|
||
|
|
From: Peter Krempa <pkrempa@redhat.com>
|
||
|
|
Date: Tue, 17 Mar 2020 17:12:45 +0100
|
||
|
|
Subject: [PATCH] qemuBlockBitmapsHandleCommitFinish: Use proper variable to
|
||
|
|
iterate
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The function repeatedly checked the first element rather than iterating
|
||
|
|
through the array.
|
||
|
|
|
||
|
|
Reported-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
|
||
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
||
|
|
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
|
||
|
|
(cherry picked from commit 7a16318855811ac4ae55d30b77969528099fd180)
|
||
|
|
https://bugzilla.redhat.com/show_bug.cgi?id=1799013
|
||
|
|
Message-Id: <25addb80a3899e5789c32aecab8184066e80cbd0.1584461519.git.pkrempa@redhat.com>
|
||
|
|
Reviewed-by: Ján Tomko <jtomko@redhat.com>
|
||
|
|
---
|
||
|
|
src/qemu/qemu_block.c | 2 +-
|
||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
|
||
|
|
index dad3e2317f..73cb5ba4bc 100644
|
||
|
|
--- a/src/qemu/qemu_block.c
|
||
|
|
+++ b/src/qemu/qemu_block.c
|
||
|
|
@@ -3175,7 +3175,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSourcePtr topsrc,
|
||
|
|
char **disabledbitmaps;
|
||
|
|
|
||
|
|
for (disabledbitmaps = disabledBitmapsBase; *disabledbitmaps; disabledbitmaps++) {
|
||
|
|
- if (STREQ(*disabledBitmapsBase, bitmap->name)) {
|
||
|
|
+ if (STREQ(*disabledbitmaps, bitmap->name)) {
|
||
|
|
bitmapdata = g_new0(struct qemuBlockBitmapsHandleCommitData, 1);
|
||
|
|
|
||
|
|
bitmapdata->create = false;
|
||
|
|
--
|
||
|
|
2.25.1
|
||
|
|
|