41 lines
1.5 KiB
Diff
41 lines
1.5 KiB
Diff
|
From d96d359a032cda609f9adf3caafdf8425d8aa4ac Mon Sep 17 00:00:00 2001
|
|||
|
|
From: Boris Fiuczynski <fiuczy@linux.ibm.com>
|
|||
|
|
Date: Thu, 13 Aug 2020 16:03:44 +0200
|
|||
|
|
Subject: [PATCH] qemu: avoid maybe-uninitialized warning by GCC 10
|
|||
|
|
MIME-Version: 1.0
|
|||
|
|
Content-Type: text/plain; charset=UTF-8
|
|||
|
|
Content-Transfer-Encoding: 8bit
|
|||
|
|
|
|||
|
|
GCC 10 complains about "well_formed_uri" may be used uninitialzed.
|
|||
|
|
Even though it is a false positive, we can easily avoid it.
|
|||
|
|
|
|||
|
|
Avoiding
|
|||
|
|
../src/qemu/qemu_migration.c: In function ‘qemuMigrationDstPrepareDirect’:
|
|||
|
|
../src/qemu/qemu_migration.c:2920:16: error: ‘well_formed_uri’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
|
|||
|
|
2920 | if (well_formed_uri) {
|
|||
|
|
| ^
|
|||
|
|
|
|||
|
|
Signed-off-by: Boris Fiuczynski <fiuczy@linux.ibm.com>
|
|||
|
|
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
|
|||
|
|
Reviewed-by: Erik Skultety <eskultet@redhat.com>
|
|||
|
|
---
|
|||
|
|
src/qemu/qemu_migration.c | 2 +-
|
|||
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|||
|
|
|
|||
|
|
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
|
|||
|
|
index 0f2f92b211..142faa2cf9 100644
|
|||
|
|
--- a/src/qemu/qemu_migration.c
|
|||
|
|
+++ b/src/qemu/qemu_migration.c
|
|||
|
|
@@ -2886,7 +2886,7 @@ qemuMigrationDstPrepareDirect(virQEMUDriverPtr driver,
|
|||
|
|
|
|||
|
|
*uri_out = g_strdup_printf(incFormat, "tcp", hostname, port);
|
|||
|
|
} else {
|
|||
|
|
- bool well_formed_uri;
|
|||
|
|
+ bool well_formed_uri = false;
|
|||
|
|
|
|||
|
|
if (!(uri = qemuMigrationAnyParseURI(uri_in, &well_formed_uri)))
|
|||
|
|
goto cleanup;
|
|||
|
|
--
|
|||
|
|
GitLab
|
|||
|
|
|