rpms/libtevent
7
0
Fork 0
Code Issues Pull Requests Releases Activity

Apply a patch from upstream to fix tevent_poll's additional_flags on 32bit architectures

Browse Source 
- Resolves: rhbz#975490
This commit is contained in:
Jakub Hrozek 2013-06-19 10:19:32 +02:00
parent 422aca710f
commit fe3912945a
2 changed files with 35 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
0001-tevent-Fix-Coverity-ID-989236-Operands-don-t-affect-.patch Normal file
View File

@ -0,0 +1,26 @@
From dd0e38b5feb51c8aa44e76bb6c84202bf8373005 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl@samba.org>
Date: Thu, 13 Jun 2013 20:35:32 +0200
Subject: [PATCH] tevent: Fix Coverity ID 989236 Operands don't affect result
"unsigned" could be less than uint64_t, so idx==UINT64_MAX is always false.
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
diff --git a/lib/tevent/tevent_poll.c b/lib/tevent/tevent_poll.c
index c6e2a00ffec6393fd6fccc1a3836f63e4ef4e045..75d0ced5a09ea86505a5df49b3c84073d3aa0f02 100644
--- a/lib/tevent/tevent_poll.c
+++ b/lib/tevent/tevent_poll.c
@@ -546,7 +546,7 @@ static int poll_event_loop_poll(struct tevent_context *ev,
the handler to remove itself when called */
for (fde = ev->fd_events; fde; fde = fde->next) {
- unsigned idx = fde->additional_flags;
+ uint64_t idx = fde->additional_flags;
struct pollfd *pfd;
uint16_t flags = 0;
--
1.8.2.1

10
libtevent.spec
View File

@ -6,7 +6,7 @@
Name: libtevent
Version: 0.9.18
Release: 1%{?dist}
Release: 2%{?dist}
Group: System Environment/Daemons
Summary: The tevent library
License: LGPLv3+
@ -24,6 +24,7 @@ BuildRequires: libxslt
Provides: bundled(libreplace)
# Patches
Patch0001: 0001-tevent-Fix-Coverity-ID-989236-Operands-don-t-affect-.patch
%description
Tevent is an event system based on the talloc memory management library.
@ -69,6 +70,8 @@ UpdateTimestamps() {
%setup -q -n tevent-%{version}
%patch0001 -p3 -b .flags
%build
%configure --disable-rpath \
--bundled-libraries=NONE \
@ -118,6 +121,11 @@ rm -rf $RPM_BUILD_ROOT
%postun -p /sbin/ldconfig
%changelog
* Wed Jun 19 2013 Jakub Hrozek <jhrozek@redhat.com> - 0.9.18-2
- Apply a patch from upstream to fix tevent_poll's additional_flags
on 32bit architectures
- Resolves: rhbz#975490
* Mon Mar 18 2013 Jakub Hrozek <jhrozek@redhat.com> - 0.9.18-1
- New upstream release 0.9.18