Spec file cleanup and improvements

libtevent.spec

@@ -1,12 +1,14 @@
 %if 0%{?fedora} || 0%{?rhel} > 7
-%global with_python3 1
+%bcond_without python3
+%else
+%bcond_with python3
 %endif
 
 %global talloc_version 2.3.0
 
 Name: libtevent
 Version: 0.10.2
-Release: 5%{?dist}
+Release: 6%{?dist}
 Summary: The tevent library
 License: LGPLv3+
 URL: http://tevent.samba.org/
@@ -24,7 +26,7 @@ BuildRequires: doxygen
 BuildRequires: docbook-style-xsl
 BuildRequires: libxslt
 BuildRequires: gnupg2
-%if 0%{?with_python3}
+%if %{with python3}
 BuildRequires: python3-devel
 BuildRequires: python3-talloc-devel >= %{talloc_version}
 %endif
@@ -48,7 +50,7 @@ Requires: libtalloc-devel%{?_isa} >= %{talloc_version}
 Header files needed to develop programs that link against the Tevent library.
 
 
-%if 0%{?with_python3}
+%if %{with python3}
 %package -n python3-tevent
 Summary: Python 3 bindings for the Tevent library
 Requires: libtevent%{?_isa} = %{version}-%{release}
@@ -80,8 +82,8 @@ doxygen doxy.config
 
 # Install API docs
 rm -f doc/man/man3/todo*
-mkdir -p $RPM_BUILD_ROOT/%{_mandir}
-cp -a doc/man/* $RPM_BUILD_ROOT/%{_mandir}
+install -d -m0755 %{buildroot}%{_mandir}
+cp -a doc/man/man3 %{buildroot}%{_mandir}
 
 %files
 %{_libdir}/libtevent.so.*
@@ -92,7 +94,7 @@ cp -a doc/man/* $RPM_BUILD_ROOT/%{_mandir}
 %{_libdir}/pkgconfig/tevent.pc
 %{_mandir}/man3/tevent*.gz
 
-%if 0%{?with_python3}
+%if %{with python3}
 %files -n python3-tevent
 %{python3_sitearch}/tevent.py
 %{python3_sitearch}/__pycache__/tevent.*
@@ -102,6 +104,9 @@ cp -a doc/man/* $RPM_BUILD_ROOT/%{_mandir}
 %ldconfig_scriptlets
 
 %changelog
+* Thu Oct 22 2020 Andreas Schneider <asn@redhat.com> - 0.10.2-6
+- Spec file cleanup and improvements
+
 * Tue Jul 28 2020 Fedora Release Engineering <releng@fedoraproject.org> - 0.10.2-5
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild