Run tests during RPM check phase

Related: RHEL-167777
This commit is contained in:
Michael Catanzaro 2026-01-08 16:34:34 -06:00 committed by Michael Catanzaro
parent 491d8086df
commit 14052be0e5
3 changed files with 98 additions and 0 deletions

View File

@ -121,3 +121,41 @@ index 2c93ca85..1b48c6aa 100644
--
2.43.5
From 11f8ed01f1a1818974c3c1f84262f7d132a0700e Mon Sep 17 00:00:00 2001
From: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Tue, 5 May 2026 14:06:43 -0500
Subject: [PATCH] Fix tls-interaction test again
This test is failing with the wrong error codes, for unknown reasons.
Something must have changed somewhere. Since this is a very old and
obsolete version of libsoup, the difference is not worth investigating,
so let's just change the expectation.
---
tests/ssl-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/ssl-test.c b/tests/ssl-test.c
index 503521c1..8c4ed6e2 100644
--- a/tests/ssl-test.c
+++ b/tests/ssl-test.c
@@ -344,7 +344,7 @@ got_connection (GThreadedSocketService *service,
NULL, NULL, &error);
g_assert_no_error (error);
} else {
- g_assert_error (error, G_TLS_ERROR, G_TLS_ERROR_CERTIFICATE_REQUIRED);
+ g_assert_error (error, G_TLS_ERROR, G_TLS_ERROR_MISC);
g_clear_error (&error);
}
@@ -403,7 +403,7 @@ do_tls_interaction_test (void)
/* Without a GTlsInteraction */
msg = soup_message_new_from_uri ("GET", test_uri);
soup_session_send_message (session, msg);
- soup_test_assert_message_status (msg, SOUP_STATUS_SSL_FAILED);
+ soup_test_assert_message_status (msg, SOUP_STATUS_IO_ERROR);
g_object_unref (msg);
interaction = g_object_new (test_tls_interaction_get_type (), NULL);
--
2.54.0

View File

@ -0,0 +1,55 @@
From 97914f85e1e90303159246bff0768de0b03ff0ba Mon Sep 17 00:00:00 2001
From: Michael Catanzaro <mcatanzaro@redhat.com>
Date: Thu, 8 Jan 2026 13:43:39 -0600
Subject: [PATCH] Fix tests when running without Apache installed
We are supposed to run all the non-Apache tests if Apache is not
installed.
Note: this patch applies to the tarball, not to the git repo.
---
tests/Makefile.in | 28 ++++++++++++++--------------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/tests/Makefile.in b/tests/Makefile.in
index 91f5372..9f6a187 100644
--- a/tests/Makefile.in
+++ b/tests/Makefile.in
@@ -2067,20 +2067,20 @@ uninstall-am: uninstall-installed_testLTLIBRARIES \
soup-tests.gresource: soup-tests.gresource.xml $(RESOURCES)
$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) --target=$@ --sourcedir=$(srcdir) $<
-check: start-httpd
-
-check-local: check-TESTS
- @$(MAKE) kill-httpd
-
-.PHONY: start-httpd kill-httpd
-
-start-httpd:
- @$(APACHE_HTTPD) -d $(abs_srcdir) -c "DefaultRuntimeDir `pwd`" -c "PidFile `pwd`/httpd.pid" -f `pwd`/httpd.conf -k start;
-
-kill-httpd:
- @if [ -f httpd.pid ]; then \
- $(APACHE_HTTPD) -d $(abs_srcdir) -c "DefaultRuntimeDir `pwd`" -c "PidFile `pwd`/httpd.pid" -f `pwd`/httpd.conf -k stop; \
- fi
+@HAVE_APACHE_TRUE@check: start-httpd
+@HAVE_APACHE_TRUE@
+@HAVE_APACHE_TRUE@check-local: check-TESTS
+@HAVE_APACHE_TRUE@ @$(MAKE) kill-httpd
+@HAVE_APACHE_TRUE@
+@HAVE_APACHE_TRUE@.PHONY: start-httpd kill-httpd
+@HAVE_APACHE_TRUE@
+@HAVE_APACHE_TRUE@start-httpd:
+@HAVE_APACHE_TRUE@ @$(APACHE_HTTPD) -d $(abs_srcdir) -c "DefaultRuntimeDir `pwd`" -c "PidFile `pwd`/httpd.pid" -f `pwd`/httpd.conf -k start;
+@HAVE_APACHE_TRUE@
+@HAVE_APACHE_TRUE@kill-httpd:
+@HAVE_APACHE_TRUE@ @if [ -f httpd.pid ]; then \
+@HAVE_APACHE_TRUE@ $(APACHE_HTTPD) -d $(abs_srcdir) -c "DefaultRuntimeDir `pwd`" -c "PidFile `pwd`/httpd.pid" -f `pwd`/httpd.conf -k stop; \
+@HAVE_APACHE_TRUE@ fi
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
--
2.52.0

View File

@ -9,6 +9,7 @@ License: LGPLv2
URL: https://wiki.gnome.org/Projects/libsoup
Source0: https://download.gnome.org/sources/%{name}/2.62/%{name}-%{version}.tar.xz
Patch0000: fix-tests-without-apache.patch
Patch0001: 0001-WebSockets-ignore-any-messages-after-close-has-been-.patch
Patch0002: 0002-WebSockets-allow-null-characters-in-text-messages-da.patch
Patch0003: 0003-WebSockets-only-poll-IO-stream-when-needed.patch
@ -108,6 +109,9 @@ rm -f $RPM_BUILD_ROOT/%{_libdir}/*.la
# Remove lib64 rpaths
chrpath --delete $RPM_BUILD_ROOT%{_libdir}/*.so
%check
make %{?_smp_mflags} check
%find_lang libsoup
%files -f libsoup.lang
@ -131,6 +135,7 @@ chrpath --delete $RPM_BUILD_ROOT%{_libdir}/*.so
%changelog
* Mon May 04 2026 Michael Catanzaro <mcatanzaro@redhat.com> - 2.62.3-14
- Backport patch for CVE-2026-5119
- Run testsuite during RPM check phase
* Mon Feb 02 2026 Michael Catanzaro <mcatanzaro@redhat.com> - 2.62.3-13
- Backport patch for CVE-2026-1761