34 lines
1022 B
Diff
34 lines
1022 B
Diff
|
From 39eb347b3c557b65085b007ce5fab93f1f32ddd1 Mon Sep 17 00:00:00 2001
|
||
|
|
From: =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com>
|
||
|
|
Date: Mon, 3 May 2021 17:11:05 +0200
|
||
|
|
Subject: [PATCH] libselinux: setexecfilecon(): drop dead assignment
|
||
|
|
MIME-Version: 1.0
|
||
|
|
Content-Type: text/plain; charset=UTF-8
|
||
|
|
Content-Transfer-Encoding: 8bit
|
||
|
|
|
||
|
|
The variable `rc` is always unconditionally assigned by the next call of
|
||
|
|
`setexeccon()` and never read in between.
|
||
|
|
|
||
|
|
Found by clang-analyzer.
|
||
|
|
|
||
|
|
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
|
||
|
|
---
|
||
|
|
libselinux/src/setexecfilecon.c | 1 -
|
||
|
|
1 file changed, 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/libselinux/src/setexecfilecon.c b/libselinux/src/setexecfilecon.c
|
||
|
|
index e72ba0d98880..2c6505a96a48 100644
|
||
|
|
--- a/libselinux/src/setexecfilecon.c
|
||
|
|
+++ b/libselinux/src/setexecfilecon.c
|
||
|
|
@@ -37,7 +37,6 @@ int setexecfilecon(const char *filename, const char *fallback_type)
|
||
|
|
newcon = strdup(context_str(con));
|
||
|
|
if (!newcon)
|
||
|
|
goto out;
|
||
|
|
- rc = 0;
|
||
|
|
}
|
||
|
|
|
||
|
|
rc = setexeccon(newcon);
|
||
|
|
--
|
||
|
|
2.32.0.rc1
|
||
|
|
|