From edb8b225daba690efb21674e95be187a111d245f Mon Sep 17 00:00:00 2001 From: Jakub Adam Date: Wed, 18 May 2016 08:58:54 +0200 Subject: [PATCH] agent: don't give up gathering when can't create socket for an IP Candidate gathering is stopped when discovery_add_local_host_candidate() returns HOST_CANDIDATE_CANT_CREATE_SOCKET. This may be too radical a measure when other local addresses can still be able to generate usable candidates. The issue was observed by a user who had an IPv6 address with tentative flag on one of the interfaces. That single failing address was causing the whole gathering process to end with no candidates found. --- agent/agent.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/agent/agent.c b/agent/agent.c index 334198b..db1e2d2 100644 --- a/agent/agent.c +++ b/agent/agent.c @@ -2783,8 +2783,7 @@ nice_agent_gather_candidates ( " s%d:%d. Invalid interface?", agent, ip, stream->id, component->id); } - ret = FALSE; - goto error; + continue; } nice_address_set_port (addr, 0); -- 2.7.4