7037828457
* Wed May 08 2024 Phil Sutter <psutter@redhat.com> [1.2.6-3.el9]
- tests: Fix objref test case (Phil Sutter) [RHEL-28515]
- expr: Respect data_len when setting attributes (Phil Sutter) [RHEL-28515]
- obj: Respect data_len when setting attributes (Phil Sutter) [RHEL-28515]
- utils: Introduce and use nftnl_set_str_attr() (Phil Sutter) [RHEL-28515]
- obj: Enforce attr_policy compliance in nftnl_obj_set_data() (Phil Sutter) [RHEL-28515]
- obj: Introduce struct obj_ops::attr_policy (Phil Sutter) [RHEL-28515]
- obj: Call obj_ops::set with legal attributes only (Phil Sutter) [RHEL-28515]
- obj: Repurpose struct obj_ops::max_attr field (Phil Sutter) [RHEL-28515]
- obj: Return value on setters (Phil Sutter) [RHEL-28515]
- object: getters take const struct (Phil Sutter) [RHEL-28515]
- utils: Fix for wrong variable use in nftnl_assert_validate() (Phil Sutter) [RHEL-28515]
- obj: synproxy: Use memcpy() to handle potentially unaligned data (Phil Sutter) [RHEL-28515]
- obj: Do not call nftnl_obj_set_data() with zero data_len (Phil Sutter) [RHEL-28515]
- table: Validate NFTNL_TABLE_OWNER, too (Phil Sutter) [RHEL-28515]
- set: Validate NFTNL_SET_ID, too (Phil Sutter) [RHEL-28515]
- obj: Validate NFTNL_OBJ_TYPE, too (Phil Sutter) [RHEL-28515]
- flowtable: Validate NFTNL_FLOWTABLE_SIZE, too (Phil Sutter) [RHEL-28515]
- table: Validate NFTNL_TABLE_USE, too (Phil Sutter) [RHEL-28515]
- chain: Validate NFTNL_CHAIN_USE, too (Phil Sutter) [RHEL-28515]
- expr: Enforce attr_policy compliance in nftnl_expr_set() (Phil Sutter) [RHEL-28515]
- expr: Introduce struct expr_ops::attr_policy (Phil Sutter) [RHEL-28515]
- include: Sync nf_log.h with kernel headers (Phil Sutter) [RHEL-28515]
- expr: Call expr_ops::set with legal types only (Phil Sutter) [RHEL-28515]
- expr: Repurpose struct expr_ops::max_attr field (Phil Sutter) [RHEL-28515]
- udata: incorrect userdata buffer size validation (Phil Sutter) [RHEL-28515]
- obj: ct_timeout: setter checks for timeout array boundaries (Phil Sutter) [RHEL-28515]
- set_elem: use nftnl_data_cpy() in NFTNL_SET_ELEM_{KEY,KEY_END,DATA} (Phil Sutter) [RHEL-28515]
- set: buffer overflow in NFTNL_SET_DESC_CONCAT setter (Phil Sutter) [RHEL-28515]
- expr: fix buffer overflows in data value setters (Phil Sutter) [RHEL-28515]
Resolves: RHEL-28515
73 lines
2.6 KiB
Diff
73 lines
2.6 KiB
Diff
From ec6136e9d14c36daf6c59fc99c051ed3ac4cd0f2 Mon Sep 17 00:00:00 2001
|
|
From: Phil Sutter <psutter@redhat.com>
|
|
Date: Wed, 8 May 2024 22:39:40 +0200
|
|
Subject: [PATCH] obj: ct_timeout: setter checks for timeout array boundaries
|
|
|
|
JIRA: https://issues.redhat.com/browse/RHEL-28515
|
|
Upstream Status: libnftnl commit 7e6a10e4a57aaf72c74c21d2ed7d2be8289d0f6f
|
|
|
|
commit 7e6a10e4a57aaf72c74c21d2ed7d2be8289d0f6f
|
|
Author: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
Date: Thu Jan 25 17:34:40 2024 +0100
|
|
|
|
obj: ct_timeout: setter checks for timeout array boundaries
|
|
|
|
Use _MAX definitions for timeout attribute arrays and check that
|
|
timeout array is not larger than NFTNL_CTTIMEOUT_ARRAY_MAX.
|
|
|
|
Fixes: 0adceeab1597 ("src: add ct timeout support")
|
|
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
|
|
|
|
Signed-off-by: Phil Sutter <psutter@redhat.com>
|
|
---
|
|
src/obj/ct_timeout.c | 11 +++++++----
|
|
1 file changed, 7 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/src/obj/ct_timeout.c b/src/obj/ct_timeout.c
|
|
index 65b48bd..fedf9e3 100644
|
|
--- a/src/obj/ct_timeout.c
|
|
+++ b/src/obj/ct_timeout.c
|
|
@@ -21,7 +21,7 @@
|
|
|
|
#include "obj.h"
|
|
|
|
-static const char *const tcp_state_to_name[] = {
|
|
+static const char *const tcp_state_to_name[NFTNL_CTTIMEOUT_TCP_MAX] = {
|
|
[NFTNL_CTTIMEOUT_TCP_SYN_SENT] = "SYN_SENT",
|
|
[NFTNL_CTTIMEOUT_TCP_SYN_RECV] = "SYN_RECV",
|
|
[NFTNL_CTTIMEOUT_TCP_ESTABLISHED] = "ESTABLISHED",
|
|
@@ -35,7 +35,7 @@ static const char *const tcp_state_to_name[] = {
|
|
[NFTNL_CTTIMEOUT_TCP_UNACK] = "UNACKNOWLEDGED",
|
|
};
|
|
|
|
-static uint32_t tcp_dflt_timeout[] = {
|
|
+static uint32_t tcp_dflt_timeout[NFTNL_CTTIMEOUT_TCP_MAX] = {
|
|
[NFTNL_CTTIMEOUT_TCP_SYN_SENT] = 120,
|
|
[NFTNL_CTTIMEOUT_TCP_SYN_RECV] = 60,
|
|
[NFTNL_CTTIMEOUT_TCP_ESTABLISHED] = 432000,
|
|
@@ -49,12 +49,12 @@ static uint32_t tcp_dflt_timeout[] = {
|
|
[NFTNL_CTTIMEOUT_TCP_UNACK] = 300,
|
|
};
|
|
|
|
-static const char *const udp_state_to_name[] = {
|
|
+static const char *const udp_state_to_name[NFTNL_CTTIMEOUT_UDP_MAX] = {
|
|
[NFTNL_CTTIMEOUT_UDP_UNREPLIED] = "UNREPLIED",
|
|
[NFTNL_CTTIMEOUT_UDP_REPLIED] = "REPLIED",
|
|
};
|
|
|
|
-static uint32_t udp_dflt_timeout[] = {
|
|
+static uint32_t udp_dflt_timeout[NFTNL_CTTIMEOUT_UDP_MAX] = {
|
|
[NFTNL_CTTIMEOUT_UDP_UNREPLIED] = 30,
|
|
[NFTNL_CTTIMEOUT_UDP_REPLIED] = 180,
|
|
};
|
|
@@ -156,6 +156,9 @@ static int nftnl_obj_ct_timeout_set(struct nftnl_obj *e, uint16_t type,
|
|
memcpy(&timeout->l4proto, data, sizeof(timeout->l4proto));
|
|
break;
|
|
case NFTNL_OBJ_CT_TIMEOUT_ARRAY:
|
|
+ if (data_len < sizeof(uint32_t) * NFTNL_CTTIMEOUT_ARRAY_MAX)
|
|
+ return -1;
|
|
+
|
|
memcpy(timeout->timeout, data,
|
|
sizeof(uint32_t) * NFTNL_CTTIMEOUT_ARRAY_MAX);
|
|
break;
|