From ac31ecf8f1c1e7836f2f2ef33abfbf7fe6587462 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Mon, 7 Apr 2025 13:40:07 +0100
Subject: [PATCH] Fix nbdcopy --blkhash crash resolves: RHEL-85509

---
 ...hen-blkhash-size-is-not-a-power-of-2.patch | 33 +++++++++++++++++++
 libnbd.spec                                   |  5 +--
 2 files changed, 36 insertions(+), 2 deletions(-)
 create mode 100644 0008-copy-Fix-crash-when-blkhash-size-is-not-a-power-of-2.patch

diff --git a/0008-copy-Fix-crash-when-blkhash-size-is-not-a-power-of-2.patch b/0008-copy-Fix-crash-when-blkhash-size-is-not-a-power-of-2.patch
new file mode 100644
index 0000000..9936408
--- /dev/null
+++ b/0008-copy-Fix-crash-when-blkhash-size-is-not-a-power-of-2.patch
@@ -0,0 +1,33 @@
+From 7c92a9c782970c168f12107eb5cf7816d4741710 Mon Sep 17 00:00:00 2001
+From: "Richard W.M. Jones" <rjones@redhat.com>
+Date: Mon, 7 Apr 2025 11:35:25 +0100
+Subject: [PATCH] copy: Fix crash when blkhash size is not a power of 2
+
+nbdcopy: blkhash.c:105: init_blkhash: Assertion `is_power_of_2 (blkhash_size)' failed.
+
+The check for this was wrong, resulting in a later assertion failure
+instead of an error message.
+
+Reported-by: Vera Wu
+Fixes: https://issues.redhat.com/browse/RHEL-85513
+(cherry picked from commit 6c6e0822c854e423d79bef87caf1c20c5bdb5eb5)
+---
+ copy/main.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/copy/main.c b/copy/main.c
+index 76b09ded..613b9ede 100644
+--- a/copy/main.c
++++ b/copy/main.c
+@@ -220,7 +220,7 @@ main (int argc, char *argv[])
+                      prog, "--blkhash", error, pstr);
+             exit (EXIT_FAILURE);
+           }
+-          if (! is_power_of_2 (blkhash_size)) {
++          if (! is_power_of_2 (i64)) {
+             fprintf (stderr, "%s: %s is not a power of two: %s\n",
+                      prog, "--blkhash", &optarg[i+1]);
+             exit (EXIT_FAILURE);
+-- 
+2.47.1
+
diff --git a/libnbd.spec b/libnbd.spec
index 6a892ff..d0564e9 100644
--- a/libnbd.spec
+++ b/libnbd.spec
@@ -21,7 +21,7 @@
 
 Name:           libnbd
 Version:        1.20.3
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        NBD client library in userspace
 
 License:        LGPL-2.0-or-later AND BSD-3-Clause
@@ -48,6 +48,7 @@ Patch0004:     0004-generator-states-newstyle.c-Quote-untrusted-string-f.patch
 Patch0005:     0005-generator-states-newstyle.c-Don-t-sign-extend-escape.patch
 Patch0006:     0006-copy-Set-the-total-size-in-bytes-copied.patch
 Patch0007:     0007-copy-Add-blkhash-option.patch
+Patch0008:     0008-copy-Fix-crash-when-blkhash-size-is-not-a-power-of-2.patch
 
 %if 0%{verify_tarball_signature}
 BuildRequires:  gnupg2
@@ -392,7 +393,7 @@ make %{?_smp_mflags} check || {
 
 
 %changelog
-* Mon Mar 31 2025 Richard W.M. Jones <rjones@redhat.com> - 1.20.3-2
+* Mon Apr 07 2025 Richard W.M. Jones <rjones@redhat.com> - 1.20.3-3
 - Add nbdcopy --blkhash option
   resolves: RHEL-85509