.gitignore

@@ -1 +1,2 @@
-SOURCES/libkdumpfile-0.5.2.tar.gz
+/libkdumpfile-*.*.*.tar.gz
+/libkdumpfile-???????.tar.gz

.libkdumpfile.metadata

@@ -1 +0,0 @@
-1770835d08f36a8ed2afa7f891742dc42a395637 SOURCES/libkdumpfile-0.5.2.tar.gz

README.md

@@ -0,0 +1,3 @@
+# libkdumpfile
+
+The libkdumpfile package

changelog

@@ -0,0 +1,20 @@
+* Tue Apr 12 2022 Neal Gompa <ngompa@datto.com> - 0.4.0-6
+- Update spec to comply with packaging guidelines
+  + Use correct globbing for libraries in file list
+  + Rename Python binding subpackage to match Python guidelines
+  + Stop globbing binaries in util subpackage
+
+* Thu Jan 20 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.0-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
+
+* Thu Jul 22 2021 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.0-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
+
+* Fri Jun 04 2021 Python Maint <python-maint@redhat.com> - 0.4.0-3
+- Rebuilt for Python 3.10
+
+* Fri Apr  2 2021 Davide Cavalca <dcavalca@fedoraproject.org> - 0.4.0-2
+- Fix license
+
+* Fri Feb 26 2021 Davide Cavalca <dcavalca@fedoraproject.org> - 0.4.0-1
+- Initial package

gating.yaml

@@ -0,0 +1,6 @@
+--- !Policy
+product_versions:
+  - rhel-10
+decision_context: osci_compose_gate
+rules:
+  - !PassingTestCaseRule {test_case_name: osci.brew-build.tier0.functional}

libkdumpfile-c99.patch

@@ -0,0 +1,45 @@
+Python 3 does not have a tp_print member in PyTypeObject
+
+This avoids an int-conversion compiler error with current compilers:
+
+./kdumpfile.c:1449:9: error: initialization of 'long int' from 'int (*)(PyObject *, FILE *, int)' {aka 'int (*)(struct _object *, FILE *, int)'} makes integer from pointer without a cast
+ 1449 |         attr_dir_print,                 /* tp_print*/
+      |         ^~~~~~~~~~~~~~
+
+In Python 3.11, the field at this position is called
+tp_vectorcall_offset and has type Py_ssize_t, hence the error.
+
+Submitted upstream: <https://github.com/ptesarik/libkdumpfile/pull/78>
+
+diff --git a/python/kdumpfile.c b/python/kdumpfile.c
+index 7c5917522ef05539..332318e76f317dff 100644
+--- a/python/kdumpfile.c
++++ b/python/kdumpfile.c
+@@ -1143,7 +1143,6 @@ attr_dir_repr(PyObject *_self)
+ 	Py_XDECREF(colon);
+ 	return result;
+ }
+-#endif
+ 
+ static int
+ attr_dir_print(PyObject *_self, FILE *fp, int flags)
+@@ -1214,6 +1213,7 @@ attr_dir_print(PyObject *_self, FILE *fp, int flags)
+ 	kdump_attr_iter_end(ctx, &iter);
+ 	return -1;
+ }
++#endif
+ 
+ static PyObject *
+ attr_iterkey_new(PyObject *_self)
+@@ -1446,7 +1446,11 @@ static PyTypeObject attr_dir_object_type =
+ 	sizeof(char),			/* tp_itemsize*/
+ 	/* methods */
+ 	attr_dir_dealloc,		/* tp_dealloc*/
++#if PY_MAJOR_VERSION < 3
+ 	attr_dir_print,			/* tp_print*/
++#else
++	0,
++#endif
+ 	0,				/* tp_getattr*/
+ 	0,				/* tp_setattr*/
+ 	0,				/* tp_compare*/

libkdumpfile.spec

@@ -2,13 +2,14 @@
 %global addrlibsover 3
 
 Name:           libkdumpfile
-Version:        0.5.2
-Release:        2%{?dist}
+Version:        0.5.4
+Release:        %autorelease
 Summary:        Kernel coredump file access
 
 License:        LGPL-3.0-or-later OR GPL-2.0-or-later
 URL:            https://github.com/ptesarik/libkdumpfile
 Source:         %{url}/releases/download/v%{version}/%{name}-%{version}.tar.gz
+Patch0: libkdumpfile-c99.patch
 
 BuildRequires:  gcc-c++
 BuildRequires:  doxygen
@@ -123,67 +124,4 @@ find $RPM_BUILD_ROOT -name '*.a' -exec rm -f {} ';'
 %{_bindir}/showxlat
 
 %changelog
-* Wed Jul 26 2023 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.5.2-1
-- Update to 0.5.2
-- Use SPDX license identifiers
-- Fix documentation build to be properly be noarch
-
-* Thu Jul 20 2023 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.1-4
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
-
-* Tue Jun 13 2023 Python Maint <python-maint@redhat.com> - 0.5.1-3
-- Rebuilt for Python 3.12
-
-* Tue Feb 07 2023 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.5.1-2
-- remove old quilt series listing
-
-* Tue Feb 07 2023 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.5.1-1
-- Update to 0.5.1
-
-* Fri Jan 20 2023 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.5.0-3
-- Minor fixes for Python 3.12 compatibility
-- Fix Python unit tests to use the right assert methods
-- Explicitly BR python3-setuptools
-
-* Thu Jan 19 2023 Fedora Release Engineering <releng@fedoraproject.org> - 0.5.0-2
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
-
-* Mon Aug 15 2022 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.5.0-1
-- Update to 0.5.0
-
-* Sat Aug 06 2022 Michel Alexandre Salim <michel@michel-slm.name> - 0.4.1^202208069184e5c-1
-- Include diskdump endianness fix
-
-* Fri Aug 05 2022 Michel Alexandre Salim <michel@michel-slm.name> - 0.4.1^202207144829feb-1
-- Update to latest Git snapshot
-
-* Thu Jul 21 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.1-7
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
-
-* Mon Jun 13 2022 Python Maint <python-maint@redhat.com> - 0.4.1-6
-- Rebuilt for Python 3.11
-
-* Thu May 19 2022 Davide Cavalca <dcavalca@fedoraproject.org> - 0.4.1-5
-- Number the patches for epel8 compatibility
-
-* Thu May 12 2022 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.4.1-4
-- Re-enable all tests on x86_64
-
-* Thu May 12 2022 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.4.1-3
-- Disable failing tests to work around upstream issue #40
-
-* Wed May 11 2022 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.4.1-2
-- Enable tests
-
-* Thu Apr 21 2022 Michel Alexandre Salim <salimma@fedoraproject.org> - 0.4.1-1
-- Update to 0.4.1
-
-* Tue Apr 12 2022 Neal Gompa <ngompa@datto.com> - 0.4.0-6
-- Update spec to comply with packaging guidelines
-  + Use correct globbing for libraries in file list
-  + Rename Python binding subpackage to match Python guidelines
-  + Stop globbing binaries in util subpackage
-
-* Thu Jan 20 2022 Fedora Release Engineering <releng@fedoraproject.org> - 0.4.0-5
-- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
-
+%autochangelog

sources

@@ -0,0 +1 @@
+SHA512 (libkdumpfile-0.5.4.tar.gz) = 40637dbdf8a5002bd649f1c94d9bd2258cb0df64efe3435f9ab51cfcce94300bf0422dcb0a4d0c535484a20b46fe6456cf7fb97164abc0673c90d2d631d3e350

tests/README

@@ -0,0 +1,2 @@
+initial tests:
+run make check, which runs any selftests in the upstream source tarball

tests/selftest/Makefile

@@ -0,0 +1,64 @@
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Makefile of /CoreOS/patch/Sanity/selftest
+#   Description: Executes upstream test suite
+#   Author: Miroslav Vadkerti <mvadkert@redhat.com>
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Copyright (c) 2010 Red Hat, Inc. All rights reserved.
+#
+#   This copyrighted material is made available to anyone wishing
+#   to use, modify, copy, or redistribute it subject to the terms
+#   and conditions of the GNU General Public License version 2.
+#
+#   This program is distributed in the hope that it will be
+#   useful, but WITHOUT ANY WARRANTY; without even the implied
+#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+#   PURPOSE. See the GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public
+#   License along with this program; if not, write to the Free
+#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#   Boston, MA 02110-1301, USA.
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+export TEST=/CoreOS/rng-tools/Sanity/selftest
+export TESTVERSION=1.0
+
+BUILT_FILES=
+
+FILES=$(METADATA) runtest.sh Makefile PURPOSE
+
+.PHONY: all install download clean
+
+run: $(FILES) build
+	./runtest.sh
+
+build: $(BUILT_FILES)
+	chmod a+x runtest.sh
+
+clean:
+	rm -f *~ $(BUILT_FILES)
+
+
+include /usr/share/rhts/lib/rhts-make.include
+
+$(METADATA): Makefile
+	@echo "Owner:           Miroslav Vadkerti <mvadkert@redhat.com>" > $(METADATA)
+	@echo "Name:            $(TEST)" >> $(METADATA)
+	@echo "TestVersion:     $(TESTVERSION)" >> $(METADATA)
+	@echo "Path:            $(TEST_DIR)" >> $(METADATA)
+	@echo "Description:     Executes upstream test suite" >> $(METADATA)
+	@echo "Type:            Sanity" >> $(METADATA)
+	@echo "TestTime:        30m" >> $(METADATA)
+	@echo "RunFor:          patch" >> $(METADATA)
+	@echo "Requires:        patch gcc rpm-build automake libselinux-devel ed libattr-devel" >> $(METADATA)
+	@echo "Priority:        Normal" >> $(METADATA)
+	@echo "License:         GPLv2" >> $(METADATA)
+	@echo "Confidential:    no" >> $(METADATA)
+	@echo "Destructive:     no" >> $(METADATA)
+	@echo "Releases:        -RHEL3 -RHEL4 -RHELServer5 -RHELClient5" >> $(METADATA)
+
+	rhts-lint $(METADATA)

tests/selftest/PURPOSE

@@ -0,0 +1,4 @@
+PURPOSE of /CoreOS/irqbalance/Sanity/selftest
+Description: Executes rngtest to validate integrity of irqbalance 
+Author: Neil Horman <nhorman@redhat.com>
+ 

tests/selftest/runtest.sh

@@ -0,0 +1,74 @@
+#!/bin/bash
+# vim: dict=/usr/share/beakerlib/dictionary.vim cpt=.,w,b,u,t,i,k
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   runtest.sh of /CoreOS/rng-tools/Sanity/selftest
+#   Description: Executes the upstream test suite comming with the package
+#   Author: Miroslav Vadkerti <mvadkert@redhat.com>
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+#
+#   Copyright (c) 2010 Red Hat, Inc. All rights reserved.
+#
+#   This copyrighted material is made available to anyone wishing
+#   to use, modify, copy, or redistribute it subject to the terms
+#   and conditions of the GNU General Public License version 2.
+#
+#   This program is distributed in the hope that it will be
+#   useful, but WITHOUT ANY WARRANTY; without even the implied
+#   warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR
+#   PURPOSE. See the GNU General Public License for more details.
+#
+#   You should have received a copy of the GNU General Public
+#   License along with this program; if not, write to the Free
+#   Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+#   Boston, MA 02110-1301, USA.
+#
+# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+# Include rhts environment
+. /usr/bin/rhts-environment.sh || exit 1
+. /usr/share/beakerlib/beakerlib.sh || exit 1
+
+PACKAGE="libkdumpfile"
+PACKAGES="libkdumpfile gcc-c++ doxygen make sed libzstd-devel lzo-devel python3-devel python3-setuptools snappy-devel zlib-ng-compat-devel rpm-build"
+UPSTREAMPKG="libkdumpfile-*"
+BUILDLOG=`mktemp`
+TESTLOG=`mktemp`
+TARGET=$(echo `uname -m` | egrep ppc)
+if [[ $TARGET != "" ]]; then TARGET="--target `uname -m`"; fi
+TOPDIR=`mktemp -d`
+SPEC="$TOPDIR/SPECS/$PACKAGE*.spec"
+TESTDIR="$TOPDIR/BUILD/$UPSTREAMPKG/"
+
+rlJournalStart
+    rlPhaseStartSetup
+    	for PKG in $PACKAGES; do
+	        rlAssertRpm $PKG
+	done
+    rlPhaseEnd
+    rlPhaseStartTest
+	rlFetchSrcForInstalled $PACKAGE
+	rlRun "rpm -ivh --define '_topdir $TOPDIR' $PACKAGE*.src.rpm" 0 "Installing $PACKAGE src rpm"
+	echo "+ Building $PACKAGE (Log: $BUILDLOG)"
+	echo "+ Build command: rpmbuild -bc $SPEC $TARGET"
+	rlRun "rpmbuild --define '_package_note_flags %nil' --define '_topdir $TOPDIR' -bc $SPEC $TARGET &> $BUILDLOG"
+	echo "+ Buildlog:"
+	tail -n 100 $BUILDLOG
+	rlRun "pushd ."
+ 	rlRun "cd $(ls -d $TESTDIR | grep -v SPEC)"
+	rlRun "make check &> $TESTLOG"   
+	if [ $? -eq 0 ]
+	then
+		rlPass "Selftest Passed"
+	else
+		rlFail "Selftest Failed"
+	fi
+    rlPhaseEnd
+
+    rlPhaseStartCleanup
+    	rlRun "popd"
+	rlRun "rm -rf $PACKAGE*.src.rpm" 0 "Removing source rpm"    
+    rlPhaseEnd
+rlJournalPrintText
+rlJournalEnd

tests/tests.yml

@@ -0,0 +1,22 @@
+---
+# This first play always runs on the local staging system
+- hosts: localhost
+  roles:
+  - role: standard-test-beakerlib
+    tags:
+    - classic
+    tests:
+    - selftest
+    required_packages:
+      - libkdumpfile
+      - gcc-c++
+      - doxygen
+      - make
+      - sed
+      - libzstd-devel
+      - lzo-devel
+      - python3-devel
+      - python3-setuptools
+      - snappy-devel
+      - zlib-ng-compat-devel
+      - rpm-build