- Package review fixes:

- Drop prereq on ldconfig.
- Removed trailing dot in devel package summary.
- Fixed devel package requirement on main package.
- Use SMP make flags.
- Removed static libraries and la files.
- Fixed source URL.
- Make sure timestamps are preserved on install.
- Ship AUTHORS and NEWS.

libieee1284.spec

@@ -1,12 +1,11 @@
 Summary: A library for interfacing IEEE 1284-compatible devices
 Name: libieee1284
 Version: 0.2.11
-Release: 5%{?dist}
+Release: 6%{?dist}
 License: GPLv2+
 Group: System Environment/Libraries
 URL: http://cyberelk.net/tim/libieee1284/
-Source0: ftp://cyberelk.net/tim/data/%{name}/devel/%{name}-%{version}.tar.bz2
-Prereq: /sbin/ldconfig
+Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.bz2
 BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildRequires: xmlto, python-devel
 
@@ -14,8 +13,8 @@ BuildRequires: xmlto, python-devel
 The libieee1284 library is for communicating with parallel port devices.
 
 %package devel
-Summary: Files for developing applications that use libieee1284.
-Requires: %{name} = %{version}
+Summary: Files for developing applications that use libieee1284
+Requires: %{name} = %{version}-%{release}
 Group: Development/Libraries
 
 %description devel
@@ -36,28 +35,28 @@ use 'import ieee1284'.
 %build
 touch doc/interface.xml
 %configure
-make CFLAGS="$RPM_OPT_FLAGS"
+make %{?_smp_mflags}
 
 %install
 rm -rf %{buildroot}
-%makeinstall
+make DESTDIR=%{buildroot} INSTALL="install -p" install
 rm -f %{buildroot}%{_libdir}/python*/*/*a
+rm -f %{buildroot}%{_libdir}/*.a
+rm -f %{buildroot}%{_libdir}/*.la
 
 %clean
 rm -rf %{buildroot}
 
 %files
 %defattr(-,root,root)
-%doc README COPYING TODO
+%doc README COPYING TODO AUTHORS NEWS
 %{_libdir}/*.so.*
 %{_bindir}/*
 
 %files devel
 %defattr(-,root,root)
 %{_includedir}/ieee1284.h
-%{_libdir}/*.a
 %{_libdir}/*.so
-%{_libdir}/*.la
 %{_mandir}/*/*
 
 %files python
@@ -69,6 +68,17 @@ rm -rf %{buildroot}
 %postun -p /sbin/ldconfig
 
 %changelog
+* Thu May 14 2009 Tim Waugh <twaugh@redhat.com> 0.2.11-6
+- Package review fixes:
+  - Drop prereq on ldconfig.
+  - Removed trailing dot in devel package summary.
+  - Fixed devel package requirement on main package.
+  - Use SMP make flags.
+  - Removed static libraries and la files.
+  - Fixed source URL.
+  - Make sure timestamps are preserved on install.
+  - Ship AUTHORS and NEWS.
+
 * Wed Feb 25 2009 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 0.2.11-5
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild