From e7b94193f29d7a2715a860deb6db0708eef8c107 Mon Sep 17 00:00:00 2001 From: Pino Toscano Date: Fri, 13 Sep 2019 12:40:34 +0200 Subject: [PATCH] v2v: -o rhv-upload: tell whether a SD actually exists If there is no DC with the specified storage domain attached to it, it can mean that the SD does not exist. (cherry picked from commit 2b39c27b7f1e72f3a3bf3a616e4576af691beb88) --- v2v/rhv-upload-precheck.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/v2v/rhv-upload-precheck.py b/v2v/rhv-upload-precheck.py index 725a8dc9e..1b344ba27 100644 --- a/v2v/rhv-upload-precheck.py +++ b/v2v/rhv-upload-precheck.py @@ -66,6 +66,15 @@ data_centers = system_service.data_centers_service().list( case_sensitive=True, ) if len(data_centers) == 0: + storage_domains = system_service.storage_domains_service().list( + search='name=%s' % params['output_storage'], + case_sensitive=True, + ) + if len(storage_domains) == 0: + # The storage domain does not even exist. + raise RuntimeError("The storage domain ‘%s’ does not exist" % + (params['output_storage'])) + # The storage domain is not attached to a datacenter # (shouldn't happen, would fail on disk creation). raise RuntimeError("The storage domain ‘%s’ is not attached to a DC" % -- 2.18.4