From 0bcd2b685d07ce0346632db97f648513049d4f83 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Mon, 13 May 2024 15:34:36 +0100 Subject: [PATCH] Remove lua, perl, ruby, php and gobject bindings in RHEL gobject has always been problematic, and currently it does not work well with the latest version of GObject. lua, perl, ruby and php are reckoned to be unused in RHEL and pose considerable difficulties to maintenance. Remove them, with a view to re-adding later if a customer complains. (cherry picked from commit 4098de8c52789f30ac9557e934b24fb1c57020af) --- libguestfs.spec | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/libguestfs.spec b/libguestfs.spec index af0227d..5aafd70 100644 --- a/libguestfs.spec +++ b/libguestfs.spec @@ -146,7 +146,6 @@ BuildRequires: ocaml-ocamldoc BuildRequires: ocaml-findlib-devel %if !0%{?rhel} BuildRequires: ocaml-ounit-devel -%endif BuildRequires: lua BuildRequires: lua-devel BuildRequires: perl-devel @@ -158,8 +157,10 @@ BuildRequires: perl(Test::Pod::Coverage) >= 1.00 BuildRequires: perl(Module::Build) BuildRequires: perl(ExtUtils::CBuilder) BuildRequires: perl(Locale::TextDomain) +%endif BuildRequires: python3-devel BuildRequires: python3-libvirt +%if !0%{?rhel} BuildRequires: ruby-devel BuildRequires: rubygem-rake # json is not pulled in automatically, see RHBZ#1325022 @@ -170,7 +171,6 @@ BuildRequires: ruby-irb BuildRequires: php-devel BuildRequires: gobject-introspection-devel BuildRequires: gjs -%if !0%{?rhel} BuildRequires: vala %endif %ifarch %{golang_arches} @@ -375,17 +375,23 @@ For developers: Language bindings: - libguestfs-gobject-devel GObject bindings and GObject Introspection +%if !0%{?rhel} +libguestfs-gobject-devel GObject bindings and GObject Introspection +%endif %ifarch %{golang_arches} golang-guestfs Go language bindings %endif +%if !0%{?rhel} lua-guestfs Lua bindings +%endif ocaml-libguestfs-devel OCaml bindings +%if !0%{?rhel} perl-Sys-Guestfs Perl bindings php-libguestfs PHP bindings +%endif python3-libguestfs Python 3 bindings - ruby-libguestfs Ruby bindings %if !0%{?rhel} + ruby-libguestfs Ruby bindings libguestfs-vala Vala language bindings %endif @@ -560,6 +566,7 @@ ocaml-%{name}-devel contains development libraries required to use the OCaml bindings for %{name}. +%if !0%{?rhel} %package -n perl-Sys-Guestfs Summary: Perl bindings for %{name} (Sys::Guestfs) Requires: %{name}%{?_isa} = %{epoch}:%{version}-%{release} @@ -567,6 +574,7 @@ Requires: %{name}%{?_isa} = %{epoch}:%{version}-%{release} %description -n perl-Sys-Guestfs perl-Sys-Guestfs contains Perl bindings for %{name} (Sys::Guestfs). +%endif %package -n python3-%{name} @@ -579,6 +587,7 @@ Requires: %{name}%{?_isa} = %{epoch}:%{version}-%{release} python3-%{name} contains Python 3 bindings for %{name}. +%if !0%{?rhel} %package -n ruby-%{name} Summary: Ruby bindings for %{name} Requires: %{name}%{?_isa} = %{epoch}:%{version}-%{release} @@ -631,7 +640,6 @@ This package is needed if you want to write software using the GObject bindings. It also contains GObject Introspection information. -%if !0%{?rhel} %package vala Summary: Vala for %{name} Requires: %{name}-devel%{?_isa} = %{epoch}:%{version}-%{release} @@ -1006,11 +1014,13 @@ rm ocaml/html/.gitignore %{_mandir}/man3/guestfs-ocaml.3* +%if !0%{?rhel} %files -n perl-Sys-Guestfs %doc perl/examples/*.pl %{perl_vendorarch}/* %{_mandir}/man3/Sys::Guestfs.3pm* %{_mandir}/man3/guestfs-perl.3* +%endif %files -n python3-%{name} @@ -1021,6 +1031,7 @@ rm ocaml/html/.gitignore %{_mandir}/man3/guestfs-python.3* +%if !0%{?rhel} %files -n ruby-%{name} %doc ruby/examples/*.rb %doc ruby/doc/site/* @@ -1058,7 +1069,6 @@ rm ocaml/html/.gitignore %{_mandir}/man3/guestfs-gobject.3* -%if !0%{?rhel} %files vala %{_datadir}/vala/vapi/libguestfs-gobject-1.0.deps %{_datadir}/vala/vapi/libguestfs-gobject-1.0.vapi @@ -1089,6 +1099,7 @@ rm ocaml/html/.gitignore %changelog * Mon May 13 2024 Richard W.M. Jones - 1:1.52.1-1 - New stable branch version 1.52.1 +- Remove lua, perl, ruby, php and gobject bindings in RHEL * Thu Jan 25 2024 Fedora Release Engineering - 1:1.52.0-7 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild