Check return value from ftell
Thanks coverity Resolves: rhbz#2176145
This commit is contained in:
		
							parent
							
								
									37892dbca7
								
							
						
					
					
						commit
						65342ad3f8
					
				| @ -156,3 +156,35 @@ index 878d7095..50071bf5 100755 | |||||||
| 2.39.1 | 2.39.1 | ||||||
| 
 | 
 | ||||||
| 
 | 
 | ||||||
|  | From 3fd3bb31597f80c76a94ea62e42d58d796beabf1 Mon Sep 17 00:00:00 2001 | ||||||
|  | From: Jakub Jelen <jjelen@redhat.com> | ||||||
|  | Date: Mon, 20 Feb 2023 16:16:01 +0100 | ||||||
|  | Subject: [PATCH] fips: Check return value from ftell | ||||||
|  | 
 | ||||||
|  | * src/fips.c (get_file_offset): Check return value of ftell to be able | ||||||
|  |   to detect errors. | ||||||
|  | --
 | ||||||
|  | 
 | ||||||
|  | Originally reported by coverity. | ||||||
|  | 
 | ||||||
|  | Signed-off-by: Jakub Jelen <jjelen@redhat.com> | ||||||
|  | ---
 | ||||||
|  |  src/fips.c | 2 ++ | ||||||
|  |  1 file changed, 2 insertions(+) | ||||||
|  | 
 | ||||||
|  | diff --git a/src/fips.c b/src/fips.c
 | ||||||
|  | index 272aabae..0d89b6da 100644
 | ||||||
|  | --- a/src/fips.c
 | ||||||
|  | +++ b/src/fips.c
 | ||||||
|  | @@ -681,6 +681,8 @@ get_file_offset (FILE *fp, ElfW (Ehdr) *ehdr_p,
 | ||||||
|  |          return gpg_error_from_syserror (); | ||||||
|  |   | ||||||
|  |        off = ftell (fp); | ||||||
|  | +      if (off < 0)
 | ||||||
|  | +        return gpg_error_from_syserror ();
 | ||||||
|  |        if (shdr.sh_type == SHT_NOTE && shdr.sh_flags == 0 && shdr.sh_size == 48) | ||||||
|  |          { | ||||||
|  |            const char header_of_the_note[] = { | ||||||
|  | -- 
 | ||||||
|  | 2.39.2 | ||||||
|  | 
 | ||||||
|  | |||||||
| @ -46,6 +46,7 @@ Patch12: libgcrypt-1.10.0-fips-indicator.patch | |||||||
| Patch13: libgcrypt-1.10.0-fips-integrity.patch | Patch13: libgcrypt-1.10.0-fips-integrity.patch | ||||||
| # 3c8b6c4a9cad59c5e1db5706f6774a3141b60210 | # 3c8b6c4a9cad59c5e1db5706f6774a3141b60210 | ||||||
| # 052c5ef4cea56772b7015e36f231fa0bcbf91410 | # 052c5ef4cea56772b7015e36f231fa0bcbf91410 | ||||||
|  | # 3fd3bb31597f80c76a94ea62e42d58d796beabf1 | ||||||
| Patch14: libgcrypt-1.10.0-fips-integrity2.patch | Patch14: libgcrypt-1.10.0-fips-integrity2.patch | ||||||
| # 06ea5b5332ffdb44a0a394d766be8989bcb6a95c | # 06ea5b5332ffdb44a0a394d766be8989bcb6a95c | ||||||
| Patch15: libgcrypt-1.10.0-fips-x931.patch | Patch15: libgcrypt-1.10.0-fips-x931.patch | ||||||
|  | |||||||
		Loading…
	
		Reference in New Issue
	
	Block a user