From 13fcc25873c128ce4657b8a4052c38034b23c75b Mon Sep 17 00:00:00 2001 From: Adam Jackson Date: Wed, 30 Aug 2017 17:27:21 -0400 Subject: [PATCH] Fix the check-programs install line to work with older libtool Seriously, libtool is awful. Here's what happens when you try to fedpkg local the old thing on F27: + libtool --mode=install install -D -p -m 0755 -t /vol1/rpmbuild/BUILDROOT/libdrm-2.4.83-1.fc28.x86_64/usr/bin drmsl Usage: /usr/bin/libtool [OPTION]... [MODE-ARG]... Try 'libtool --help' for more information. libtool: error: '.' must be an absolute directory name error: Bad exit status from /var/tmp/rpm-tmp.mTAso1 (%install) Bad exit status from /var/tmp/rpm-tmp.mTAso1 (%install) Do you see a . anywhere in that line? I sure don't. Do you want to read libtool to figure out what it's doing wrong? Me neither. Whatever, the old thing worked, just switch back (but preserve the -p etc). --- libdrm.spec | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libdrm.spec b/libdrm.spec index 37fe976..69f2e30 100644 --- a/libdrm.spec +++ b/libdrm.spec @@ -7,7 +7,7 @@ Name: libdrm Summary: Direct Rendering Manager runtime library Version: 2.4.83 -Release: 1%{?dist} +Release: 2%{?dist} License: MIT URL: https://dri.freedesktop.org @@ -84,7 +84,7 @@ popd pushd tests mkdir -p %{buildroot}%{_bindir} for foo in $(make check-programs) ; do - libtool --mode=install install -D -p -m 0755 -t %{buildroot}%{_bindir} $foo + libtool --mode=install install -D -p -m 0755 $foo %{buildroot}%{_bindir} done popd # SUBDIRS=libdrm @@ -227,6 +227,10 @@ rm -f %{buildroot}%{_includedir}/%{name}/{r300_reg.h,via_3d_reg.h} %{_mandir}/man7/drm*.7* %changelog +* Wed Aug 30 2017 Adam Jackson - 2.4.83-2 +- Fix the check-programs install line to work with older libtool +- Seriously, libtool is awful + * Sun Aug 27 2017 Igor Gnatenko - 2.4.83-1 - Update to 2.4.83