From 551a83052ff92fa975f1015e2fc25b174f85b0e6 Mon Sep 17 00:00:00 2001 From: Aleš Matěj Date: Tue, 26 Oct 2021 09:33:51 +0200 Subject: [PATCH] Add unittest for setting up repo with empty keyfile (RhBug:1994614) The test ensures we don't crash when the keyfile is empty/not loaded. Test for: https://github.com/rpm-software-management/libdnf/commit/be66d0908d939ddaf3022c5489012bd1dbdb0075 RHEL bug: https://bugzilla.redhat.com/show_bug.cgi?id=1994614 Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1946024 --- tests/libdnf/dnf-self-test.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/tests/libdnf/dnf-self-test.c b/tests/libdnf/dnf-self-test.c index 32a21e6..5295837 100644 --- a/tests/libdnf/dnf-self-test.c +++ b/tests/libdnf/dnf-self-test.c @@ -199,6 +199,26 @@ ch_test_repo_func(void) g_object_unref(context); } +static void +dnf_repo_setup_with_empty_keyfile(void) +{ + DnfContext *context = dnf_context_new(); + dnf_context_set_release_ver(context, "33"); + DnfRepo *repo = dnf_repo_new(context); + GKeyFile *empty_key_file = g_key_file_new(); + + dnf_repo_set_keyfile(repo, empty_key_file); + + GError *error = NULL; + // Empty key file is not an errror, there is just no configuration to be loaded. + g_assert(dnf_repo_setup(repo, &error)); + g_assert_no_error(error); + + g_object_unref(repo); + g_object_unref(context); + g_key_file_free(empty_key_file); +} + static guint _allow_cancel_updates = 0; static guint _action_updates = 0; static guint _package_progress_updates = 0; @@ -1217,6 +1237,7 @@ main(int argc, char **argv) g_test_add_func("/libdnf/lock", dnf_lock_func); g_test_add_func("/libdnf/lock[threads]", dnf_lock_threads_func); g_test_add_func("/libdnf/repo", ch_test_repo_func); + g_test_add_func("/libdnf/repo_empty_keyfile", dnf_repo_setup_with_empty_keyfile); g_test_add_func("/libdnf/state", dnf_state_func); g_test_add_func("/libdnf/state[child]", dnf_state_child_func); g_test_add_func("/libdnf/state[parent-1-step]", dnf_state_parent_one_step_proxy_func); -- libgit2 1.1.0