- tests: Remove unreliable nvme attribute checks

Resolves: RHEL-16126
This commit is contained in:
Tomas Bzatek 2023-11-28 15:37:54 +01:00
parent e28fe6dd8e
commit a7afe387c1
2 changed files with 37 additions and 1 deletions

View File

@ -0,0 +1,31 @@
From 6067dbdf0fe3c2d83055c43edf35cddf277e7236 Mon Sep 17 00:00:00 2001
From: Tomas Bzatek <tbzatek@redhat.com>
Date: Fri, 10 Nov 2023 14:09:20 +0100
Subject: [PATCH] tests: Remove unreliable nvme attribute checks
Some attributes like this health information data read counters
are just too volatile to be tested as there might be some other
processes probing the device causing the statistics counters to increase.
---
tests/nvme_test.py | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/nvme_test.py b/tests/nvme_test.py
index 3c7c0a29..f31de546 100644
--- a/tests/nvme_test.py
+++ b/tests/nvme_test.py
@@ -157,14 +157,12 @@ def test_smart_log(self):
self.assertEqual(log.critical_temp_time, 0)
self.assertEqual(log.ctrl_busy_time, 0)
self.assertEqual(log.media_errors, 0)
- # self.assertEqual(log.num_err_log_entries, 0)
self.assertEqual(log.percent_used, 0)
self.assertEqual(log.power_cycles, 0)
self.assertEqual(log.power_on_hours, 0)
self.assertEqual(log.spare_thresh, 0)
self.assertEqual(log.temp_sensors, [0, 0, 0, 0, 0, 0, 0, 0])
self.assertEqual(log.temperature, 0)
- self.assertGreater(log.total_data_read, 1)
self.assertEqual(log.unsafe_shutdowns, 0)
self.assertEqual(log.warning_temp_time, 0)
self.assertEqual(log.wctemp, 0)

View File

@ -129,7 +129,7 @@
Name: libblockdev
Version: 2.28
Release: 10%{?dist}
Release: 11%{?dist}
Summary: A library for low-level manipulation with block devices
License: LGPLv2+
URL: https://github.com/storaged-project/libblockdev
@ -147,6 +147,7 @@ Patch9: 0009-Fix-issues-in-tests-when-running-in-FIPS-mode.patch
Patch10: 0010-lvm-Add-a-function-to-activate-LVs-in-shared-mode.patch
Patch11: 0011-nvme_libblockdev-3.0.4_backport.patch
Patch12: 0012-lvm-Add-support-for-starting-and-stopping-VG-locking.patch
Patch13: 0013-tests-Remove_unreliable_nvme_attribute_checks.patch
BuildRequires: make
BuildRequires: glib2-devel
@ -1045,6 +1046,10 @@ find %{buildroot} -type f -name "*.la" | xargs %{__rm}
%files plugins-all
%changelog
* Tue Nov 28 2023 Tomas Bzatek <tbzatek@redhat.com> - 2.28-11
- tests: Remove unreliable nvme attribute checks
Resolves: RHEL-16126
* Wed Nov 08 2023 Vojtech Trefny <vtrefny@redhat.com> - 2.28-10
- lvm: Add support for starting and stopping VG locking
Resolves: RHEL-15921