Address not important coverity scan issues

This commit is contained in:
Jakub Jelen 2021-04-07 12:12:48 +02:00
parent 8491f7478c
commit df0ee9cc6c
2 changed files with 24 additions and 0 deletions

View File

@ -0,0 +1,22 @@
commit f2bf4b1e81d46dc00e3d478dd88fd994a944d4d5
Author: Jakub Jelen <jjelen@redhat.com>
Date: Wed Apr 7 12:09:59 2021 +0200
tests: Avoid leaking file descriptors on errors
--
Signed-off-by: Jakub Jelen <jjelen@redhat.com>
diff --git a/tests/fdpassing.c b/tests/fdpassing.c
index 3e1b71b..0e23ffc 100644
--- a/tests/fdpassing.c
+++ b/tests/fdpassing.c
@@ -176,6 +176,7 @@ client (assuan_context_t ctx, const char *fname)
rc = assuan_sendfd (ctx, fileno (fp));
if (rc)
{
+ fclose (fp);
log_error ("assuan_sendfd failed: %s\n", gpg_strerror (rc));
return -1;
}

View File

@ -10,6 +10,7 @@ Source1: https://gnupg.org/ftp/gcrypt/libassuan/libassuan-%{version}.tar.bz2.sig
URL: https://www.gnupg.org/ URL: https://www.gnupg.org/
Patch1: libassuan-2.5.2-multilib.patch Patch1: libassuan-2.5.2-multilib.patch
Patch2: libassuan-2.5.5-coverity.patch
BuildRequires: gcc BuildRequires: gcc
BuildRequires: gawk BuildRequires: gawk
@ -37,6 +38,7 @@ This package contains files needed to develop applications using %{name}.
%setup -q %setup -q
%patch1 -p1 -b .multilib %patch1 -p1 -b .multilib
%patch2 -p1 -b .coverity
%build %build