53 lines
2.6 KiB
Diff
53 lines
2.6 KiB
Diff
From a3a0c1d59f72c5c367b2541a510e01d08c470266 Mon Sep 17 00:00:00 2001
|
|
From: Petr Stodulka <pstodulk@redhat.com>
|
|
Date: Mon, 22 Jun 2026 15:02:05 +0200
|
|
Subject: [PATCH 105/108] [9/9] targetcontentresolver: Make TODO notes
|
|
|
|
The current refactoring progressed significantly, but there are still
|
|
anti-patterns and bugs in the code, which cannot be easily resolved
|
|
without the second part of the refactoring. Due to lack of time, we
|
|
decided to stop here, considering the situation much better in
|
|
comparison to the previous state. Making notes in the code about
|
|
additional expected changes so we do not forget them :)
|
|
|
|
Co-authored-by: Matej Matuska <mmatuska@redhat.com>
|
|
Jira: RHEL-115867
|
|
Signed-off-by: Petr Stodulka <pstodulk@redhat.com>
|
|
---
|
|
.../libraries/targetcontentresolver.py | 19 +++++++++++++++++++
|
|
1 file changed, 19 insertions(+)
|
|
|
|
diff --git a/repos/system_upgrade/common/actors/targetcontentresolver/libraries/targetcontentresolver.py b/repos/system_upgrade/common/actors/targetcontentresolver/libraries/targetcontentresolver.py
|
|
index 83460d99..f969d0f9 100644
|
|
--- a/repos/system_upgrade/common/actors/targetcontentresolver/libraries/targetcontentresolver.py
|
|
+++ b/repos/system_upgrade/common/actors/targetcontentresolver/libraries/targetcontentresolver.py
|
|
@@ -142,6 +142,25 @@ def process():
|
|
source repos, installed package repos, and custom/blacklisted repo
|
|
configuration.
|
|
"""
|
|
+ # TODO: update pes_even_scanner to work just with PESIDs instead of repoids.
|
|
+ # The blocklisted events needs to be then evaluated / calculated after
|
|
+ # the setuptargetrepos calculations. Similarly we can update the blocklist
|
|
+ # library. The setuptargetrepos tells exactly what's going to be allowed
|
|
+ # (repoids) and based on that we can finish the calculations.
|
|
+ # This includes:
|
|
+ # * all reports will be generated (or directly called) from the orchestrator
|
|
+ # * all/most of messages should be produced in the orchestrator
|
|
+ # * we will need at least 2 public functions in pes_events_scanner
|
|
+ # # and repositoriesblocklist libs:
|
|
+ # # * these that we have right now
|
|
+ # # * additional ones for the final calculation / filtering based on
|
|
+ # # the real list of blocklisted repoids
|
|
+ # TL;DR; the workflow will be like this:
|
|
+ # * Make interim pes-events calculation (work just with PESIDS)
|
|
+ # * Make interim blocklist calculation
|
|
+ # * Calc expected & really blocked target repositories
|
|
+ # * take the result and finish the calculation
|
|
+ # * generate reports & messages
|
|
indata = InputData()
|
|
repomap_handler = _init_repomap_handler()
|
|
blocklisted_repoids = repositoriesblocklist.compute_blocklist(
|
|
--
|
|
2.54.0
|
|
|