From 279ebc96c45ab597f9c26903f5b36e2e57ced6fe Mon Sep 17 00:00:00 2001 From: Petr Stodulka Date: Fri, 30 Sep 2022 11:17:38 +0200 Subject: [PATCH 17/32] firewalldcheckallowzonedrifting: Fix the remediation cmd The remediation cmd was incorrect as the cmd is written as string instead of list, the fix: ['cmd param param'] -> ['cmd', 'paramm', 'param'] JIRA: OAMG-7694 --- .../el8toel9/actors/firewalldcheckallowzonedrifting/actor.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/repos/system_upgrade/el8toel9/actors/firewalldcheckallowzonedrifting/actor.py b/repos/system_upgrade/el8toel9/actors/firewalldcheckallowzonedrifting/actor.py index 1f2767f5..b7eb5806 100644 --- a/repos/system_upgrade/el8toel9/actors/firewalldcheckallowzonedrifting/actor.py +++ b/repos/system_upgrade/el8toel9/actors/firewalldcheckallowzonedrifting/actor.py @@ -46,6 +46,6 @@ class FirewalldCheckAllowZoneDrifting(Actor): title='Changes in firewalld related to Zone Drifting'), reporting.Remediation( hint='Set AllowZoneDrifting=no in /etc/firewalld/firewalld.conf', - commands=[['sed -i "s/^AllowZoneDrifting=.*/AllowZoneDrifting=no/" ' + commands=[['sed', '-i', 's/^AllowZoneDrifting=.*/AllowZoneDrifting=no/', '/etc/firewalld/firewalld.conf']]), ]) -- 2.38.1