From f20072a011c46d10f997c40daf9e821dd9cacffb Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 3 Jun 2019 13:55:20 +0200 Subject: [PATCH] Don't use the expired certificate the tarball provides for tests Resolves: #1705700 - lasso FTBFS because an expired certificate is used in the tests --- ...-use-of-an-expired-cert-in-tests-as-.patch | 32 +++++++++++++++++++ lasso.spec | 8 ++++- 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 0005-tests-Remove-the-use-of-an-expired-cert-in-tests-as-.patch diff --git a/0005-tests-Remove-the-use-of-an-expired-cert-in-tests-as-.patch b/0005-tests-Remove-the-use-of-an-expired-cert-in-tests-as-.patch new file mode 100644 index 0000000..a1d5cc4 --- /dev/null +++ b/0005-tests-Remove-the-use-of-an-expired-cert-in-tests-as-.patch @@ -0,0 +1,32 @@ +From 690947183fb7621b2f16df493819b771b7b29431 Mon Sep 17 00:00:00 2001 +From: Jakub Hrozek +Date: Mon, 3 Jun 2019 13:30:27 +0200 +Subject: [PATCH] tests: Remove the use of an expired cert in tests as a + workaround + +The test used to verify the signature of the IDP metadata in +test13_test_lasso_server_load_metadata() expired at "Mar 23 09:51:37 +2019 GMT" + +This patch just removes the certificate usage from +lasso_server_load_metadata() which means we don't validate the metadata, +but we can keep the rest of the test at least. +--- + tests/basic_tests.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/tests/basic_tests.c b/tests/basic_tests.c +index c08cab69..212f37ef 100644 +--- a/tests/basic_tests.c ++++ b/tests/basic_tests.c +@@ -1983,7 +1983,7 @@ START_TEST(test13_test_lasso_server_load_metadata) + block_lasso_logs; + check_good_rc(lasso_server_load_metadata(server, LASSO_PROVIDER_ROLE_IDP, + TESTSDATADIR "/metadata/renater-metadata.xml", +- TESTSDATADIR "/metadata/metadata-federation-renater.crt", ++ NULL, + &blacklisted_1, &loaded_entity_ids, + LASSO_SERVER_LOAD_METADATA_FLAG_DEFAULT)); + unblock_lasso_logs; +-- +2.20.1 diff --git a/lasso.spec b/lasso.spec index 67c78ae..6c8a97b 100644 --- a/lasso.spec +++ b/lasso.spec @@ -58,7 +58,7 @@ Summary: Liberty Alliance Single Sign On Name: lasso Version: 2.6.0 -Release: 12%{?dist} +Release: 13%{?dist} License: GPLv2+ URL: http://lasso.entrouvert.org/ Source: http://dev.entrouvert.org/lasso/lasso-%{version}.tar.gz @@ -67,6 +67,7 @@ Patch1: use-specified-python-interpreter.patch Patch2: build-scripts-py3-compatible.patch Patch3: duplicate-python-LogoutTestCase.patch Patch4: versioned-python-configure.patch +Patch5: 0005-tests-Remove-the-use-of-an-expired-cert-in-tests-as-.patch BuildRequires: autoconf BuildRequires: automake @@ -317,6 +318,11 @@ rm -fr %{buildroot}%{_defaultdocdir}/%{name} %endif %changelog +* Mon Jun 3 2019 Jakub Hrozek - 2.6.0-13 +- Don't use the expired certificate the tarball provides for tests +- Resolves: #1705700 - lasso FTBFS because an expired certificate is + used in the tests + * Fri May 31 2019 Jitka Plesnikova - 2.6.0-12 - Perl 5.30 rebuild