From d94dedd385fa7619c52bf3b47621aed65d4a9f55 Mon Sep 17 00:00:00 2001
From: Xavier Bachelot <xavier@bachelot.org>
Date: Mon, 3 Dec 2018 15:47:45 +0100
Subject: [PATCH] Consolidate BuildRequires

---
 lasso.spec | 51 +++++++++++++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 22 deletions(-)

diff --git a/lasso.spec b/lasso.spec
index 6831692..b602f5d 100644
--- a/lasso.spec
+++ b/lasso.spec
@@ -68,34 +68,50 @@ Patch2: build-scripts-py3-compatible.patch
 Patch3: duplicate-python-LogoutTestCase.patch
 Patch4: versioned-python-configure.patch
 
-BuildRequires: libtool autoconf automake
-
-%if %{with_perl}
-BuildRequires: perl-generators
+BuildRequires: autoconf
+BuildRequires: automake
+BuildRequires: check-devel
+BuildRequires: glib2-devel
+BuildRequires: gtk-doc
+BuildRequires: libtool
+BuildRequires: libtool-ltdl-devel
+BuildRequires: libxml2-devel
+BuildRequires: openssl-devel
+BuildRequires: swig
+BuildRequires: xmlsec1-devel >= 1.2.25-4
+BuildRequires: xmlsec1-openssl-devel >= 1.2.25-4
+BuildRequires: zlib-devel
+%if %{with_java}
+BuildRequires: java-devel
+BuildRequires: jpackage-utils
+%endif
+%if %{with_perl}
+BuildRequires: perl-devel
+BuildRequires: perl-generators
+BuildRequires: perl(Error)
+BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(Test::More)
+%endif
+%if %{with_php}
+BuildRequires: expat-devel
+BuildRequires: php-devel
 %endif
-
 # The Lasso build system requires python, especially the binding generators
 %if %{with_python2}
 BuildRequires: python2
+BuildRequires: python2-devel
 BuildRequires: python2-lxml
 BuildRequires: python2-six
 %endif
-
 %if %{with_python3}
 BuildRequires: python3
+BuildRequires: python3-devel
 BuildRequires: python3-lxml
 BuildRequires: python3-six
 %endif
-
 %if %{with_wsf}
 BuildRequires: cyrus-sasl-devel
 %endif
-BuildRequires: gtk-doc, libtool-ltdl-devel
-BuildRequires: glib2-devel, swig
-BuildRequires: libxml2-devel, openssl-devel 
-BuildRequires: xmlsec1-devel >= 1.2.25-4, xmlsec1-openssl-devel >= 1.2.25-4
-BuildRequires: zlib-devel, check-devel
-BuildRequires: libtool autoconf automake
 Url: http://lasso.entrouvert.org/
 
 Requires: xmlsec1 >= 1.2.25-4
@@ -119,10 +135,6 @@ documentation for Lasso.
 %package -n perl-%{name}
 Summary: Liberty Alliance Single Sign On (lasso) Perl bindings
 Group: Development/Libraries
-BuildRequires: perl-devel
-BuildRequires: perl(ExtUtils::MakeMaker)
-BuildRequires: perl(Test::More)
-BuildRequires: perl(Error)
 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
 Requires: %{name}%{?_isa} = %{version}-%{release}
 
@@ -134,8 +146,6 @@ Perl language bindings for the lasso (Liberty Alliance Single Sign On) library.
 %package -n java-%{name}
 Summary: Liberty Alliance Single Sign On (lasso) Java bindings
 Group: Development/Libraries
-BuildRequires: java-devel
-BuildRequires: jpackage-utils
 Requires: java-headless
 Requires: jpackage-utils
 Requires: %{name}%{?_isa} = %{version}-%{release}
@@ -153,7 +163,6 @@ Java language bindings for the lasso (Liberty Alliance Single Sign On) library.
 %package -n php-%{name}
 Summary: Liberty Alliance Single Sign On (lasso) PHP bindings
 Group: Development/Libraries
-BuildRequires: php-devel, expat-devel
 Requires: %{name}%{?_isa} = %{version}-%{release}
 Requires: php(zend-abi) = %{php_zend_api}
 Requires: php(api) = %{php_core_api}
@@ -168,7 +177,6 @@ PHP language bindings for the lasso (Liberty Alliance Single Sign On) library.
 %{?python_provide:%python_provide python2-%{name}}
 Summary: Liberty Alliance Single Sign On (lasso) Python bindings
 Group: Development/Libraries
-BuildRequires: python2-devel
 Requires: python2
 Requires: %{name}%{?_isa} = %{version}-%{release}
 %if %{obsolete_old_lang_subpackages}
@@ -187,7 +195,6 @@ library.
 %{?python_provide:%python_provide python3-%{name}}
 Summary: Liberty Alliance Single Sign On (lasso) Python bindings
 Group: Development/Libraries
-BuildRequires: python3-devel
 Requires: python3
 Requires: %{name}%{?_isa} = %{version}-%{release}