rpms/kmod
5
0
Fork 0
Code Issues Pull Requests Releases Activity

weak-modules: split modules into array with read -a

Browse Source 
Coverity reports warning for splitting mods=($i)
`Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a.`

Even if it can not cause problems for weak-modules case where the
list is coming from modules.dep, use the recommended read -a method.

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
This commit is contained in:
Yauheni Kaliuta 2021-06-08 11:44:42 +03:00 committed by Yauheni Kaliuta
parent 35bc85d1e4
commit 50733019f1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
weak-modules
View File

@ -935,7 +935,7 @@ do_make_groups()
declare -a mods declare -a mods
while read i; do while read i; do
mods=($i) read -a mods <<< "$i"
echo "${mods[0]}" |grep -q "extra/" || continue echo "${mods[0]}" |grep -q "extra/" || continue
@ -987,7 +987,7 @@ filter_extra_absoluted()
# to speed up handling in general cases # to speed up handling in general cases
echo "$i" |grep -q "extra/" || continue echo "$i" |grep -q "extra/" || continue
mods=($i) read -a mods <<< "$i"
for j in "${!mods[@]}"; do for j in "${!mods[@]}"; do
mod="${mods[$j]}" mod="${mods[$j]}"