Remove weak-modules from kmod in Fedora

Fedora does not support CONFIG_MODVERSIONS, as we have no guarantee of
KABI.  With this in mind, the weak-modules script adds no benefit to
Fedora, but it can cause serious issues with update times on major
kernel rebases, and with dkms.  This patch removes the script from
Fedora, but leaves it in place for ELN/CentOS/RHEL, etc.

Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>

kmod.spec

@@ -44,6 +44,14 @@ Requires:	%{name}-libs%{?_isa} = %{version}-%{release}
 The kmod-devel package provides header files used for development of
 applications that wish to load or unload Linux kernel modules.
 
+# Fedora does not support CONFIG_MODVERSIONS. Without kabi support
+# weak-modules is useless at best, and can be actively harmful.
+%if 0%{?fedora}
+%define with_weak_modules 0
+%else
+%define with_weak_modules 1
+%endif
+
 %prep
 %autosetup -p1
 
@@ -77,7 +85,9 @@ mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/modprobe.d
 mkdir -p $RPM_BUILD_ROOT%{_sysconfdir}/depmod.d
 mkdir -p $RPM_BUILD_ROOT%{_prefix}/lib/modprobe.d
 
+%if %{with_weak_modules}
 install -pm 755 %{SOURCE1} $RPM_BUILD_ROOT%{_sbindir}/weak-modules
+%endif
 
 %files
 %dir %{_sysconfdir}/depmod.d
@@ -90,7 +100,9 @@ install -pm 755 %{SOURCE1} $RPM_BUILD_ROOT%{_sbindir}/weak-modules
 %{_sbindir}/rmmod
 %{_sbindir}/lsmod
 %{_sbindir}/depmod
+%if %{with_weak_modules}
 %{_sbindir}/weak-modules
+%endif
 %{_datadir}/bash-completion/
 %attr(0644,root,root) %{_mandir}/man5/*.5*
 %attr(0644,root,root) %{_mandir}/man8/*.8*
@@ -106,6 +118,9 @@ install -pm 755 %{SOURCE1} $RPM_BUILD_ROOT%{_sbindir}/weak-modules
 %{_libdir}/libkmod.so
 
 %changelog
+* Mon May 24 2021 Justin M. Forbes <jforbes@fedoraproject.org>
+- Remove weak-modules for Fedora as it causes problems.
+
 * Fri May 14 2021 Josh Boyer <jwboyer@fedoraproject.org> - 29-1
 - New upstream v29
 - Resolves: rhbz#1962980