From 2815bad792862360b5359e895ff0919c50d16b3d Mon Sep 17 00:00:00 2001
From: Yauheni Kaliuta <ykaliuta@redhat.com>
Date: Thu, 9 Feb 2023 16:13:21 +0200
Subject: [PATCH] man/rmmod: explain why modprobe -r is more useful (28-8)

Improve user experience by explaining the option so the user may not
search explanations in other manpages (modprobe).

Update also generated rmmod.8 to avoid building from xml with access
to external resources.

Resolves: rhbz#2164253

Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
---
 kmod.spec                                     |  8 ++-
 ...xplain-why-modprobe-r-is-more-useful.patch | 58 +++++++++++++++++++
 2 files changed, 65 insertions(+), 1 deletion(-)
 create mode 100644 man-rmmod-explain-why-modprobe-r-is-more-useful.patch

diff --git a/kmod.spec b/kmod.spec
index a8b902b..7e7fb0a 100644
--- a/kmod.spec
+++ b/kmod.spec
@@ -1,6 +1,6 @@
 Name:		kmod
 Version:	28
-Release:	7%{?dist}
+Release:	8%{?dist}
 Summary:	Linux kernel module management utilities
 
 License:	GPLv2+
@@ -10,6 +10,8 @@ Source1:	weak-modules
 Source2:	depmod.conf.dist
 Exclusiveos:	Linux
 
+Patch01:	man-rmmod-explain-why-modprobe-r-is-more-useful.patch
+
 BuildRequires:  gcc
 BuildRequires:	chrpath
 BuildRequires:	zlib-devel
@@ -109,6 +111,10 @@ install -m 0644 %{SOURCE2} $RPM_BUILD_ROOT%{_sysconfdir}/depmod.d/dist.conf
 %{_libdir}/libkmod.so
 
 %changelog
+* Thu Feb  9 2023 Yauheni Kaliuta <ykaliuta@redhat.com> - 28-8
+- man/rmmod: explain why modprobe -r is more useful
+  Resolves: rhbz#2164253
+
 * Thu Oct 21 2021 Yauheni Kaliuta <ykaliuta@redhat.com> - 28-7
 - Add RHEL gating configuration. Related: rhbz#1985100
 
diff --git a/man-rmmod-explain-why-modprobe-r-is-more-useful.patch b/man-rmmod-explain-why-modprobe-r-is-more-useful.patch
new file mode 100644
index 0000000..b659bf7
--- /dev/null
+++ b/man-rmmod-explain-why-modprobe-r-is-more-useful.patch
@@ -0,0 +1,58 @@
+From 06fadcc6b17c3b9a534540dd6d74b0c5fb1d948d Mon Sep 17 00:00:00 2001
+From: Yauheni Kaliuta <ykaliuta@redhat.com>
+Date: Thu, 2 Feb 2023 15:47:36 +0200
+Subject: [PATCH] man/rmmod: explain why modprobe -r is more useful
+
+Improve user experience by explaining the option so the user may
+not search explanations in other manpages (modprobe).
+
+Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
+Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
+Signed-off-by: Lucas De Marchi <lucas.de.marchi@gmail.com>
+---
+ man/rmmod.xml | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/man/rmmod.xml b/man/rmmod.xml
+index e7c7e5f9e7dc..67bcbedd972b 100644
+--- a/man/rmmod.xml
++++ b/man/rmmod.xml
+@@ -52,7 +52,8 @@
+       want to use
+       <citerefentry>
+         <refentrytitle>modprobe</refentrytitle><manvolnum>8</manvolnum>
+-      </citerefentry> with the <option>-r</option> option instead.
++      </citerefentry> with the <option>-r</option> option instead
++      since it removes unused dependent modules as well.
+     </para>
+   </refsect1>
+ 
+--- a/man/rmmod.8	2020-12-28 02:58:30.085851136 +0200
++++ b/man/rmmod.8	2023-02-09 16:55:55.967128297 +0200
+@@ -2,12 +2,12 @@
+ .\"     Title: rmmod
+ .\"    Author: Jon Masters <jcm@jonmasters.org>
+ .\" Generator: DocBook XSL Stylesheets vsnapshot <http://docbook.sf.net/>
+-.\"      Date: 12/27/2020
++.\"      Date: 02/09/2023
+ .\"    Manual: rmmod
+ .\"    Source: kmod
+ .\"  Language: English
+ .\"
+-.TH "RMMOD" "8" "12/27/2020" "kmod" "rmmod"
++.TH "RMMOD" "8" "02/09/2023" "kmod" "rmmod"
+ .\" -----------------------------------------------------------------
+ .\" * Define some portability stuff
+ .\" -----------------------------------------------------------------
+@@ -39,7 +39,7 @@
+ \fBmodprobe\fR(8)
+ with the
+ \fB\-r\fR
+-option instead\&.
++option instead since it removes unused dependent modules as well\&.
+ .SH "OPTIONS"
+ .PP
+ \fB\-v\fR, \fB\-\-verbose\fR
+-- 
+2.39.1
+