269c26972d
prepare_cmdline is totally broken. For example if the remove list ($2) is empty it removes all white spaces or if a parameter has a quoted value containing a white space it only removes the first part of the parameter up to the first space. Thus add a test case that shows what the function should do in order to fix it in subsequent patches. Signed-off-by: Philipp Rudo <prudo@redhat.com> Reviewed-by: Coiby Xu <coxu@redhat.com>
84 lines
2.0 KiB
Bash
84 lines
2.0 KiB
Bash
#!/bin/bash
|
|
Describe 'kdump-lib'
|
|
Include ./kdump-lib.sh
|
|
|
|
Describe 'get_system_size()'
|
|
|
|
PROC_IOMEM=$(mktemp -t spec_test_proc_iomem_file.XXXXXXXXXX)
|
|
|
|
cleanup() {
|
|
rm -rf "$PROC_IOMEM"
|
|
}
|
|
|
|
AfterAll 'cleanup'
|
|
|
|
ONE_GIGABYTE='000000-3fffffff : System RAM'
|
|
Parameters
|
|
1
|
|
3
|
|
End
|
|
|
|
It 'should return correct system RAM size'
|
|
echo -n >"$PROC_IOMEM"
|
|
for _ in $(seq 1 "$1"); do echo "$ONE_GIGABYTE" >>"$PROC_IOMEM"; done
|
|
When call get_system_size
|
|
The output should equal "$1"
|
|
End
|
|
|
|
End
|
|
|
|
Describe 'get_recommend_size()'
|
|
# Testing stragety:
|
|
# 1. inclusive for the lower bound of the range of crashkernel
|
|
# 2. exclusive for the upper bound of the range of crashkernel
|
|
# 3. supports ranges not sorted in increasing order
|
|
|
|
ck="4G-64G:256M,2G-4G:192M,64G-1T:512M,1T-:12345M"
|
|
Parameters
|
|
1 0M
|
|
2 192M
|
|
64 512M
|
|
1024 12345M
|
|
"$((64 * 1024))" 12345M
|
|
End
|
|
|
|
It 'should handle all cases correctly'
|
|
When call get_recommend_size "$1" $ck
|
|
The output should equal "$2"
|
|
End
|
|
End
|
|
|
|
Describe 'prepare_cmdline()'
|
|
get_bootcpu_apicid() {
|
|
echo 1
|
|
}
|
|
|
|
get_watchdog_drvs() {
|
|
echo foo
|
|
}
|
|
|
|
add="disable_cpu_apicid=1 foo.pretimeout=0"
|
|
|
|
Parameters
|
|
#test cmdline remove add result
|
|
"#1" "a b c" "" "" "a b c"
|
|
"#2" "a b c" "b" "" "a c"
|
|
"#3" "a b=x c" "b" "" "a c"
|
|
"#4" "a b='x y' c" "b" "" "a c"
|
|
"#5" "a b='x y' c" "b=x" "" "a c"
|
|
"#6" "a b='x y' c" "b='x y'" "" "a c"
|
|
"#7" "a b c" "" "x" "a b c x"
|
|
"#8" "a b c" "" "x=1" "a b c x=1"
|
|
"#9" "a b c" "" "x='1 2'" "a b c x='1 2'"
|
|
"#10" "a b c" "a" "x='1 2'" "b c x='1 2'"
|
|
"#11" "a b c" "x" "x='1 2'" "a b c x='1 2'"
|
|
End
|
|
|
|
It "Test $1: should generate the correct kernel command line"
|
|
When call prepare_cmdline "$2" "$3" "$4"
|
|
The output should equal "$5 $add"
|
|
End
|
|
End
|
|
|
|
End
|