294c965ca3
qemu is launched in nested subprocess and can't be killed by simply killing the job ids, PID Command 2269634 │ ├─ sshd: root [priv] 2269637 │ │ └─ sshd: root@pts/0 2269638 │ │ └─ -bash 2269744 │ │ └─ make test-run V=1 2273117 │ │ └─ /bin/bash /root/kexec-tools-300/tests/scripts/run-test.sh 2273712 │ │ ├─ /bin/bash /root/kexec-tools-300/tests/scripts/run-test.sh 2273714 │ │ │ └─ /bin/bash /root/kexec-tools-300/tests/scripts/run-test.sh 2273737 │ │ │ └─ timeout --foreground 10m /root/kexec-tools-300/tests/scripts/run-qemu -nodefaults -nographic -smp 2 -m 768M -monitor no 2273738 │ │ │ └─ /usr/bin/qemu-system-x86_64 -enable-kvm -cpu host -nodefaults -nographic -smp 2 -m 768M -monitor none -serial stdio 2273746 │ │ │ ├─ /usr/bin/qemu-system-x86_64 -enable-kvm -cpu host -nodefaults -nographic -smp 2 -m 768M -monitor none -serial std 2273797 │ │ ├─ /bin/bash /root/kexec-tools-300/tests/scripts/run-test.sh 2273798 │ │ │ └─ /bin/bash /root/kexec-tools-300/tests/scripts/run-test.sh 2273831 │ │ │ └─ timeout --foreground 10m /root/kexec-tools-300/tests/scripts/run-qemu -nodefaults -nographic -smp 2 -m 768M -monitor no 2273832 │ │ │ └─ /usr/bin/qemu-system-x86_64 -enable-kvm -cpu host -nodefaults -nographic -smp 2 -m 768M -monitor none -serial stdio 2273840 │ │ │ ├─ /usr/bin/qemu-system-x86_64 -enable-kvm -cpu host -nodefaults -nographic -smp 2 -m 768M -monitor none -serial std This led to the error "qemu-system-x86_64: can't bind ip=0.0.0.0 to socket: Address already in use". This patch will kill qemu by killing all the children of the job id. Signed-off-by: Coiby Xu <coxu@redhat.com> Acked-by: Kairui Song <kasong@redhat.com>
178 lines
3.9 KiB
Bash
Executable File
178 lines
3.9 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
_kill_if_valid_pid() {
|
|
local _pid="$1"
|
|
if ps -p "$_pid" > /dev/null
|
|
then
|
|
kill "$_pid"
|
|
fi
|
|
}
|
|
|
|
_recursive_kill() {
|
|
local _pid="$1"
|
|
local _children _child
|
|
|
|
_children=$(pgrep -P "$_pid")
|
|
if [ -n "$_children" ]; then
|
|
for _child in $_children
|
|
do
|
|
_recursive_kill "$_child"
|
|
_kill_if_valid_pid "$_child"
|
|
done
|
|
fi
|
|
_kill_if_valid_pid "$_pid"
|
|
}
|
|
|
|
_kill_all_jobs() {
|
|
local _jobs=$(jobs -r -p)
|
|
local _job
|
|
|
|
if [ -n "$_jobs" ]; then
|
|
for _job in $_jobs
|
|
do
|
|
_recursive_kill "$_job"
|
|
done
|
|
fi
|
|
}
|
|
|
|
trap '
|
|
ret=$?;
|
|
_kill_all_jobs
|
|
exit $ret;
|
|
' EXIT
|
|
|
|
trap 'exit 1;' SIGINT
|
|
|
|
BASEDIR=$(realpath $(dirname "$0"))
|
|
. $BASEDIR/test-lib.sh
|
|
TESTCASEDIR="$BASEDIR/testcases"
|
|
|
|
console=0
|
|
testcases=""
|
|
|
|
while [ $# -gt 0 ]; do
|
|
case $1 in
|
|
'')
|
|
break
|
|
;;
|
|
--console )
|
|
console=1
|
|
;;
|
|
-*)
|
|
echo "Invalid option $1"
|
|
;;
|
|
*)
|
|
testcases+=" $1"
|
|
;;
|
|
esac
|
|
shift;
|
|
done
|
|
|
|
if [ -z "$testcases" ]; then
|
|
echo "==== Starting all tests: ===="
|
|
testcases=$(ls -1 $TESTCASEDIR)
|
|
else
|
|
echo "==== Starting specified tests: ===="
|
|
fi
|
|
echo ${testcases##*/}
|
|
echo
|
|
|
|
declare -A results
|
|
ret=0
|
|
|
|
for test_case in $testcases; do
|
|
echo "======== Running Test Case $test_case ========"
|
|
results[$test_case]="<Test Skipped>"
|
|
|
|
testdir=$TESTCASEDIR/$test_case
|
|
script_num=$(ls -1 $testdir | wc -l)
|
|
scripts=$(ls -r -1 $testdir | tr '\n' ' ')
|
|
test_outputs=""
|
|
read main_script aux_script <<< "$scripts"
|
|
|
|
if [ -z "$main_script" ]; then
|
|
echo "ERROR: Empty testcase dir $testdir"
|
|
continue
|
|
fi
|
|
|
|
for script in $scripts; do
|
|
echo "---- Building image for: $script ----"
|
|
echo "-------- Output image is: $(get_test_image $testdir/$script)"
|
|
echo "-------- Building log is: $(get_test_image $testdir/$script).log"
|
|
|
|
mkdir -p $(dirname $(get_test_image $testdir/$script))
|
|
build_test_image $testdir/$script &> $(get_test_image $testdir/$script).log
|
|
|
|
if [ $? -ne 0 ]; then
|
|
echo "Failing building image!"
|
|
continue 2
|
|
fi
|
|
done
|
|
|
|
for script in $aux_script; do
|
|
echo "---- Starting VM: $script ----"
|
|
|
|
script="$testdir/$script"
|
|
echo "-------- Qemu cmdline: $(get_test_qemu_cmd_file $script)"
|
|
echo "-------- Console log: $(get_test_console_file $script)"
|
|
echo "-------- Test log: $(get_test_output_file $script)"
|
|
test_outputs+="$(get_test_output_file $script) "
|
|
|
|
rm -f $(get_test_console_file $script)
|
|
rm -f $(get_test_output_file $script)
|
|
|
|
$(run_test_sync $script > $(get_test_console_file $script)) &
|
|
|
|
sleep 5
|
|
done
|
|
|
|
script="$main_script"
|
|
echo "---- Starting test VM: $(basename $script) ----"
|
|
script="$testdir/$script"
|
|
|
|
echo "-------- Qemu cmdline: $(get_test_qemu_cmd_file $script)"
|
|
echo "-------- Console log: $(get_test_console_file $script)"
|
|
echo "-------- Test log: $(get_test_output_file $script)"
|
|
test_outputs+="$(get_test_output_file $script) "
|
|
|
|
rm -f $(get_test_console_file $script)
|
|
rm -f $(get_test_output_file $script)
|
|
|
|
if [ $console -eq 1 ]; then
|
|
run_test_sync $script | tee $(get_test_console_file $script)
|
|
[ -n "$(jobs -p)" ] && kill $(jobs -p)
|
|
else
|
|
$(run_test_sync $script > $(get_test_console_file $script)) &
|
|
watch_test_outputs $test_outputs
|
|
fi
|
|
|
|
res="$(gather_test_result $test_outputs)"
|
|
|
|
[ $? -ne 0 ] && ret=$(expr $ret + 1)
|
|
results[$test_case]="$res"
|
|
_kill_all_jobs
|
|
echo -e "-------- Test finished: $test_case $res --------"
|
|
for script in $scripts; do
|
|
script="$testdir/$script"
|
|
output="$(get_test_output_file $script) "
|
|
image="$(get_test_image $script)"
|
|
vmcore="$(sed -n 's/^VMCORE: \(\S*\).*/\1/p' $output)"
|
|
kernel="$(sed -n 's/^KERNEL VERSION: \(\S*\).*/\1/p' $output)"
|
|
if [ -n "$vmcore" ]; then
|
|
echo "You can retrive the verify the vmcore file using following command:"
|
|
echo "./scripts/copy-from-image.sh \\"
|
|
echo " $image \\"
|
|
echo " $vmcore ./"
|
|
echo "Kernel package verion is: $kernel"
|
|
fi
|
|
done
|
|
done
|
|
|
|
echo "======== Test results ========"
|
|
for i in ${!results[@]}; do
|
|
echo "----------------"
|
|
echo -e "$i:\t\t${results[$i]}"
|
|
done
|
|
|
|
exit $ret
|