This is a backport of the following upstream commit. It is about freeing the wrong bitmap thing, it could increase the risk of OOM when system is in an edge of OOM. commit 0e7b1a6e3c1919c9222b662d458637ddf802dd04 Author: Arthur Zou <zzou@redhat.com> Date: Wed May 7 17:54:16 2014 +0900 [PATCH v3] Fix free bitmap_buffer_cyclic error. Description: In create_dump_bitmap() and write_kdump_pages_and_bitmap_cyclic(), What should be freed is info->partial_bitmap instead of info->bitmap. Solution: Add two functions to free the bitmap_buffer_cyclic. info->partial_bitmap1 is freed by free_bitmap1_buffer_cyclic(). info->partial_bitmap2 is freed by free_bitmap2_buffer_cyclic(). At the same time, remove thoes frees that free partial_bitmap1 or partial_bitmap2 at the end of main() because partial_bitmap1 and partial_bitmap2 has been freed after dump file has been written out, so there is no need to free it again at the end of main. Signed-off-by: Arthur Zou <zzou@redhat.com> Signed-off-by: Baoquan He <bhe@redhat.com> Acked-by: Vivek Goyal <vgoyal@redhat.com> |
||
---|---|---|
anaconda-addon | ||
po | ||
.gitignore | ||
98-kexec.rules | ||
README | ||
dracut-kdump.sh | ||
dracut-module-setup.sh | ||
dracut-monitor_dd_progress | ||
firstboot_kdump.py | ||
kdump-dep-generator.sh | ||
kdump-in-cluster-environment.txt | ||
kdump-lib.sh | ||
kdump.conf | ||
kdump.conf.5 | ||
kdump.service | ||
kdump.sysconfig | ||
kdump.sysconfig.i386 | ||
kdump.sysconfig.ppc64 | ||
kdump.sysconfig.s390x | ||
kdump.sysconfig.x86_64 | ||
kdumpctl | ||
kexec-kdump-howto.txt | ||
kexec-tools-2.0.3-disable-kexec-test.patch | ||
kexec-tools-2.0.4-makedumpfile-Fix-Makefile-for-eppic_makedumpfile.so-build.patch | ||
kexec-tools-2.0.4-makedumpfile-Fix-free-bitmap_buffer_cyclic-error.patch | ||
kexec-tools-2.0.4-makedumpfile-Introduce-the-mdf_pfn_t-type.patch | ||
kexec-tools.spec | ||
mkdumprd | ||
mkdumprd.8 | ||
rhcrashkernel-param | ||
sources | ||
zanata-notes.txt |
README
Adding a patch to kexec-tools ============================= There is a mailing list kexec@lists.fedoraproject.org where all the dicussion related to fedora kexec-tools happen. All the patches are posted there for inclusion and committed to kexec-tools after review. So if you want your patches to be included in fedora kexec-tools package, post these to kexec@lists.fedoraproject.org. One can subscribe to list and browse through archives here. https://admin.fedoraproject.org/mailman/listinfo/kexec