rpms/kexec-tools
7
0
Fork 0
Code Issues Pull Requests Releases Activity
Unnamed repository
535 Commits 9 Branches 67 Tags 3.3 MiB
Shell 91.1%
Roff 8.9%
55c7158d16
Go to file
Baoquan He 55c7158d16 makedumpfile: wrong cyclic buffer size recalculation causes bitmap data corruption 
Description of Problem:

In cyclic mode, makedumpfile recalculates cyclic buffer size as the
largest multiple of the largest block size managed by buddy
allocator, i.e. 4MB, smaller than the cyclic buffer size in order to
enable to process each unit of blocks managed by buddy allocator in
each cycle.

However, makedumpfile does two wrong things in the recalculations:

1) While updating size of cyclic buffer, makedumpfile doesn't update
length of range of cycle in page frame numbers, due to which, if
cyclic buffer size is updated, because cyclic buffer size is always
reduced during udpate, some buffer overrun can happen on the cyclic
buffer. This can cause segmentation violation in the worst case.

2) roundup() is used to calculate bitmap size for maximum block size
managed by buddy allocator, here divideup() is correct, due to
which, although memory filtering is not affected, cyclic buffer size
get too much aligned and less efficient.

Fix patches has already been posted and merged in makedumpfile
development devel branch.

git://git.code.sf.net/p/makedumpfile/code
f8c8218856effc43ea01cd9394761cfb8aeaa8df
a785fa7dd7a7bd7dcbb017d0bea8848243b0924f

Signed-off-by: Baoquan He <bhe@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: WANG Chao <chaowang@redhat.com>
2013-10-29 13:15:46 +08:00
po Update translation file po/it.po 2013-01-28 14:02:09 +08:00
.gitignore pull makedumpfile-1.5.4 2013-07-12 10:50:10 +08:00
98-kexec.rules udev rules fix 2012-05-28 09:50:47 +08:00
dracut-kdump.sh Strip inline comments from the kdump config file before use 2013-09-27 10:09:25 +08:00
dracut-module-setup.sh Strip inline comments from the kdump config file before use 2013-09-27 10:09:25 +08:00
dracut-monitor_dd_progress monitor-dd-progress fix 2013-06-25 16:45:59 +08:00
firstboot_kdump.py firstboot:fix reserve mem ui spinbox step size 2012-12-12 17:15:10 +08:00
kdump-lib.sh kdump-lib.sh: strip_comments is not implemented correcty 2013-10-12 16:00:12 +08:00
kdump.conf add dracut_args option to kdump.conf 2013-04-27 10:44:48 +08:00
kdump.conf.5 add dracut_args option to kdump.conf 2013-04-27 10:44:48 +08:00
kdump.init - Fix a syntax error in kdump init script 2010-06-13 21:54:34 +00:00
kdump.service kdump.service: Start kdump after network is online and remote fs is mounted 2013-09-27 10:07:13 +08:00
kdump.sysconfig do not mount root twice 2012-07-12 11:15:35 +08:00
kdump.sysconfig.i386 kdump.sysconfig: default to "nofail" mount 2013-09-27 15:45:24 +08:00
kdump.sysconfig.ia64 Mass Update of RHEL5 patches 2008-06-05 15:18:53 +00:00
kdump.sysconfig.ppc64 kdump.sysconfig: default to "nofail" mount 2013-09-27 15:45:24 +08:00
kdump.sysconfig.s390x kdump.sysconfig: default to "nofail" mount 2013-09-27 15:45:24 +08:00
kdump.sysconfig.x86_64 kdump.sysconfig: default to "nofail" mount 2013-09-27 15:45:24 +08:00
kdumpctl Strip inline comments from the kdump config file before use 2013-09-27 10:09:25 +08:00
kexec-kdump-howto.txt kexec-kdump-howto: Add a section for debugging tips 2013-06-25 14:01:57 +08:00
kexec-tools-2.0.3-build-makedumpfile-eppic-shared-object.patch pull makedumpfile-1.5.4 2013-07-12 10:50:10 +08:00
kexec-tools-2.0.3-disable-kexec-test.patch Disable kexec_test 2012-01-21 16:56:07 +08:00
kexec-tools-2.0.4-kexec-i386-Add-cmdline_add_memmap_internal-to-reduce.patch Back port 2 revert commits 2013-09-27 17:01:24 +08:00
kexec-tools-2.0.4-makedumpfile-Add-vmap_area_list-definition-for-ppc-ppc64.patch makedumpfile: Add vmap_area_list definition for ppc/ppc64. 2013-07-18 16:05:56 +08:00
kexec-tools-2.0.4-makedumpfile-Fix-max_mapnr-issue-on-system-has-over-44-b.patch Fix max_mapnr issue on system has over 44-bit addressing. 2013-10-28 17:33:16 +08:00
kexec-tools-2.0.4-makedumpfile-PATCH-Support-newer-kernels.patch makedumpfile support kernel 3.10 2013-09-27 10:05:33 +08:00
kexec-tools-2.0.4-makedumpfile-Update-pfn_cyclic-when-the-cyclic-buffer-size-.patch makedumpfile: wrong cyclic buffer size recalculation causes bitmap data corruption 2013-10-29 13:15:46 +08:00
kexec-tools-2.0.4-makedumpfile-Use-divideup-to-calculate-maximum-required-bit.patch makedumpfile: wrong cyclic buffer size recalculation causes bitmap data corruption 2013-10-29 13:15:46 +08:00
kexec-tools-2.0.4-Revert-kexec-include-reserved-e820-sections-in-crash.patch Back port 2 revert commits 2013-09-27 17:01:24 +08:00
kexec-tools-2.0.4-Revert-kexec-lengthen-the-kernel-command-line-image.patch Back port 2 revert commits 2013-09-27 17:01:24 +08:00
kexec-tools.spec makedumpfile: wrong cyclic buffer size recalculation causes bitmap data corruption 2013-10-29 13:15:46 +08:00
mkdumprd kdump.sysconfig: default to "nofail" mount 2013-09-27 15:45:24 +08:00
mkdumprd.8 Remove comma which is redundant 2013-02-16 15:19:41 +08:00
rhcrashkernel-param rhcrashkernel-param: echo crashkernel=auto for rhel7 2012-08-20 15:01:47 +08:00
sources pull makedumpfile-1.5.4 2013-07-12 10:50:10 +08:00
zanata-notes.txt Add a notes for zanata process 2012-12-05 01:23:09 -05:00