Unnamed repository
Go to file
Pingfan Liu 44100b9a8a mkdumprd: Fix makedumpfile parameter check
Resolves: https://issues.redhat.com/browse/RHEL-38358
Upstream: kdump-utils

commit 247c7a5f39b305f9a83bad2d936d00237165b7e0
Author: Mamoru Nishibe (Fujitsu) <nishibe.mamoru@fujitsu.com>
Date:   Wed Apr 24 08:11:12 2024 +0000

    mkdumprd: Fix makedumpfile parameter check.

    If only "makedumpfile" is written in "core_collector" of /etc/kdump.conf
    and try to run makedumpfile without options,
    "makedumpfile --check-params" fails and terminates abnormally.

        # grep ^core_collector /etc/kdump.conf
        core_collector makedumpfile
        # /usr/bin/kdumpctl start
        :
        Commandline parameter is invalid.
        Try `makedumpfile --help' for more information.
        kdump: makedumpfile parameter check failed.
        kdump: mkdumprd: failed to make kdump initrd
        kdump: Starting kdump: [FAILED]

    On the other hand, "makedumpfile --check-params" works fine without any options.

        # makedumpfile --check-params vmcore dumpfile
        # echo $?
        0

    In addition, before verify_core_collector() was implemented,
    initial RAM for kdump was successfully created using only "core_collector makedumpfile".
    I consider it a regression.

    This is due to a parameter extraction error in verify_core_collector().
    Fix it to correctly extract only the options as follows.

    Fixes: a1c28126 ("mkdumprd: Use makedumpfile --check-params option")
    Signed-off-by: Mamoru Nishibe <nishibe.mamoru@fujitsu.com>
    Reviewed-by: Coiby Xu <coxu@redhat.com>

Signed-off-by: Pingfan Liu <piliu@redhat.com>
2024-06-18 09:46:19 +08:00
.gitignore Release 2.0.26-1 2023-04-11 10:22:55 +08:00
60-kdump.install Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
98-kexec.rules Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
98-kexec.rules.ppc64 Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-early-kdump-module-setup.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-early-kdump.sh powerpc: update kdumpctl to load kernel signing key for fadump 2023-11-08 12:28:00 +00:00
dracut-fadump-init-fadump.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-fadump-module-setup.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-kdump-capture.service Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-kdump-emergency.service Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-kdump-emergency.target Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-kdump-error-handler.service Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-kdump-error-handler.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-kdump.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
dracut-module-setup.sh dracut-module-setup: Skip initrd-cleanup and initrd-parse-etc in kdump 2024-02-21 10:10:16 +08:00
dracut-monitor_dd_progress Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
early-kdump-howto.txt Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
fadump-howto.txt Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
gating.yaml Bring gating.yaml over from Brew dist-git 2023-03-10 10:47:36 -08:00
gen-kdump-conf.sh Auto sync2gitlab import of kexec-tools-2.0.25-3.el8.src.rpm 2022-12-13 06:13:47 +00:00
kdump-dep-generator.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump-in-cluster-environment.txt Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump-lib-initramfs.sh Auto sync2gitlab import of kexec-tools-2.0.25-5.el8.src.rpm 2023-01-20 10:15:07 +00:00
kdump-lib.sh powerpc: update kdumpctl to load kernel signing key for fadump 2023-11-08 12:28:00 +00:00
kdump-logger.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump-migrate-action.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump-restart.sh Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump-udev-throttler Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump.conf.5 Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump.service Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kdump.sysconfig Auto sync2gitlab import of kexec-tools-2.0.24-3.el8.src.rpm 2022-06-16 04:49:01 +00:00
kdump.sysconfig.aarch64 Auto sync2gitlab import of kexec-tools-2.0.24-3.el8.src.rpm 2022-06-16 04:49:01 +00:00
kdump.sysconfig.i386 Auto sync2gitlab import of kexec-tools-2.0.24-3.el8.src.rpm 2022-06-16 04:49:01 +00:00
kdump.sysconfig.ppc64 Auto sync2gitlab import of kexec-tools-2.0.24-3.el8.src.rpm 2022-06-16 04:49:01 +00:00
kdump.sysconfig.ppc64le Auto sync2gitlab import of kexec-tools-2.0.24-3.el8.src.rpm 2022-06-16 04:49:01 +00:00
kdump.sysconfig.s390x sysconfig: add zfcp.allow_lun_scan to KDUMP_COMMANDLINE_REMOVE on s390 2023-03-15 18:24:55 +08:00
kdump.sysconfig.x86_64 Auto sync2gitlab import of kexec-tools-2.0.24-3.el8.src.rpm 2022-06-16 04:49:01 +00:00
kdumpctl kdumpctl: Only returns immediately after an error occurs in check_*_modified 2023-11-17 14:16:51 +08:00
kdumpctl.8 Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kexec-kdump-howto.txt Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
kexec-tools-2.0.26-makedumpfile-sadump-fix-failure-of-reading-memory-when-5-le.patch sadump: fix failure of reading memory when 5-level paging is enabled 2023-04-12 11:25:10 +08:00
kexec-tools.spec Release 2.0.26-14 2024-02-21 16:54:47 +08:00
live-image-kdump-howto.txt Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
mkdumprd mkdumprd: Fix makedumpfile parameter check 2024-06-18 09:46:19 +08:00
mkdumprd.8 Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
mkfadumprd Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
rhelonly-kexec-tools-2.0.16-koji-build-fail-workaround.patch Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
rhelonly-kexec-tools-2.0.18-eppic-fix-issues-with-hardening-flags.patch Auto sync2gitlab import of kexec-tools-2.0.20-68.el8.src.rpm 2022-05-26 10:04:08 -04:00
rhelonly-kexec-tools-2.0.20-makedumpfile-arm64-Add-support-for-ARMv8.2-LVA-52-bi.patch Rebase makedumpfile to 1.7.2 2023-04-04 12:35:43 +08:00
sources Release 2.0.26-1 2023-04-11 10:22:55 +08:00
supported-kdump-targets.txt Add lvm thin provision to kdump supported-kdump-targets.txt 2023-08-28 13:53:38 +08:00