Unnamed repository
021f5a146e
Resolves: RHEL-46773
commit 3028529915d3026e62b59d8f3faadddd410baa75
Author: Philipp Rudo <prudo@redhat.com>
Date: Fri Jun 14 11:48:24 2024 +0200
kdumpctl: Drop default kexec '-d' option
Kernel commits cbc2fe9d9cb2 ("kexec_file: add kexec_file flag to control
debug printing") and a85ee18c7900 ("kexec_file: print out debugging
message if required") added debug messages to the kexec_file_load system
call when option -d is provided to the kexec user space tool. As
kexec_file_load is the default and option -d is set by default these
messages are always printed when a crash kernel is loaded. This not only
clutters the kernel log but also potentially leaks confidential kernel
information to users. As the messages are printed to the kernel log, not
stderr, the redirection to /var/log/kdump.log won't catch them. This
will become even more problematic as for RHEL10 the kernel will be built
without support for the kexec_load system call. So kexec_file_load will
be the only choice in the future.
The redirection also caused confusion in a recent bug report. There a
user moved a working /etc/sysconfig/kdump from ppc to s390 with
KEXEC_ARGS containing the --dt-no-old-root option. This option is arch
specific and does not exist on s390. Thus the kexec-tools failed with an
'unrecognized option' error followed by the usage(). The problem was
that the 'unrecognized option' error is printed to stderr, which got
redirected to /var/log/kdump.log, while the usage() is printed to
stdout, which ended up in the systemd journal. This caused confusion as
the user only checked the journal and found the usage() without any
error message.
Thus remove the default -d option and the redirection of stderr to
/var/log/kdump.log for the kexec-tools user space tool.
This commit ultimately reverts
|
||
|---|---|---|
| spec | ||
| tests | ||
| .editorconfig | ||
| .gitignore | ||
| .packit.yaml | ||
| .shellspec | ||
| 0001-dracut-module-setup-Fix-missing-systemd-system.conf-.patch | ||
| 0001-kdumpctl-Drop-default-kexec-d-option.patch | ||
| 0001-Use-grep-q-cmd-instead-of-cmd-grep-q.patch | ||
| 0002-mkdumprd-Fix-makedumpfile-parameter-check.patch | ||
| 0003-Try-to-install-PHY-and-MDIO-bus-drivers-explicitly.patch | ||
| 0004-Install-the-driver-of-physical-device-for-a-SR-IOV-v.patch | ||
| 0005-update-98-kexec-rules-for-crash-hotplug.patch | ||
| 0006-sysconfig-add-pcie_ports-compat-to-KDUMP_COMMANDLINE.patch | ||
| 0007-fadump-udev-do-not-re-register-fadump-if-kernel-hotp.patch | ||
| gating.yaml | ||
| kexec-tools-2.0.28-Fix-building-on-x86_64-with-binutils-2.41.patch | ||
| kexec-tools-2.0.28-kexec-don-t-use-kexec_file_load-on-XEN.patch | ||
| kexec-tools-2.0.28-makedumfpile-0001-PATCH-ppc64-get-vmalloc-start-address-from-vmcoreinf.patch | ||
| kexec-tools-2.0.28-makedumpfile-0002-PATCH-Fix-failure-of-hugetlb-pages-exclusion-on-Linu.patch | ||
| kexec-tools-2.0.28-makedumpfile-0003-PATCH-Fix-wrong-exclusion-of-Slab-pages-on-Linux-6.1.patch | ||
| kexec-tools.spec | ||
| README | ||
| README.packit | ||
| sources | ||
Adding a patch to kexec-tools ============================= There is a mailing list kexec@lists.fedoraproject.org where all the dicussion related to fedora kexec-tools happen. All the patches are posted there for inclusion and committed to kexec-tools after review. So if you want your patches to be included in fedora kexec-tools package, post these to kexec@lists.fedoraproject.org. One can subscribe to list and browse through archives here. https://admin.fedoraproject.org/mailman/listinfo/kexec