From fb9545bb2aa9a3235cc1fb3be04916af87ddbc43 Mon Sep 17 00:00:00 2001 From: Tao Liu Date: Fri, 11 Nov 2022 11:42:13 +0800 Subject: [PATCH] Don't check fs modified when dump target is lvm2 thinp upstream: fedora resolves: bz2083475 conflict: none commit 3ae8cf8876edd6ca668890f55d4c006e28a41f90 Author: Tao Liu Date: Thu Nov 10 10:25:58 2022 +0800 Don't check fs modified when dump target is lvm2 thinp When the dump target is lvm2 thinp, if we didn't mount the dump target first, get_fs_type_from_target will get empty output: Before mount: $ get_fs_type_from_target /dev/vg00/thinlv After mount: $ mount /dev/vg00/thinlv /mnt $ get_fs_type_from_target /dev/vg00/thinlv ext4 As a result, kdumpctl start will fail with: $ kdumpctl start kdump: Dump target is invalid kdump: Starting kdump: [FAILED] This patch fix the issue by bypassing check_fs_modified when the dump target is lvm2 thinp. Signed-off-by: Tao Liu Reviewed-by: Coiby Xu Signed-off-by: Tao Liu --- kdumpctl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/kdumpctl b/kdumpctl index 35b4fd1..00f1c53 100755 --- a/kdumpctl +++ b/kdumpctl @@ -476,8 +476,9 @@ check_fs_modified() fi # No need to check in case of raw target. - # Currently we do not check also if ssh/nfs/virtiofs target is specified - if is_ssh_dump_target || is_nfs_dump_target || is_raw_dump_target || is_virtiofs_dump_target; then + # Currently we do not check also if ssh/nfs/virtiofs/thinp target is specified + if is_ssh_dump_target || is_nfs_dump_target || is_raw_dump_target || + is_virtiofs_dump_target || is_lvm2_thinp_dump_target; then return 0 fi