rpms/kexec-tools
7
0
Fork 0
Code Issues Pull Requests Releases Activity

Let _update_kernel_cmdline return the correct return code

Browse Source 
Currently, for non-s390x systems, the return code is 1 even when
_update_kernel_cmdline is correctly executed. This makes callers like
reset_crashkernel_after_update fail to print a message if a kernel has
its crashkernel updated. Fix it by put the code inside if block for
s390x.

Signed-off-by: Coiby Xu <coxu@redhat.com>
Reviewed-by: Philipp Rudo <prudo@redhat.com>
This commit is contained in:
Coiby Xu 2023-04-21 19:09:51 +08:00
parent 443a43e075
commit cdc0253a3c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kdumpctl
View File

@ -1445,7 +1445,11 @@ _update_kernel_cmdline()
grubby --args="fadump=$_fadump_val" --update-kernel "$_kernel_path" grubby --args="fadump=$_fadump_val" --update-kernel "$_kernel_path"
fi fi
fi fi
[[ -f /etc/zipl.conf ]] && zipl > /dev/null
# Don't use "[[ CONDITION ]] && COMMAND" which returns 1 under false CONDITION
if [[ -f /etc/zipl.conf ]]; then
zipl > /dev/null
fi
} }
_valid_grubby_kernel_path() _valid_grubby_kernel_path()