From c7ed468aebe4fe29bd95679a00ecfca6935146a7 Mon Sep 17 00:00:00 2001 From: WANG Chao Date: Tue, 8 Apr 2014 13:15:26 +0800 Subject: [PATCH] mkdumprd: stop passing nofail mount option In current systemd implementation, nofail mount will not block local-fs.target, which means our kdump.sh (in dracut-pre-pivot.service) can't wait for nofail mount. And kdump.sh could run early than nofail mount happens. For short term, let's stop passing nofail to mount. As for sysroot.mount, since we have explicitly specify to wait for it, "nofail" isn't a problem. Signed-off-by: WANG Chao Acked-by: Vivek Goyal --- mkdumprd | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mkdumprd b/mkdumprd index 0376320..b49b74f 100644 --- a/mkdumprd +++ b/mkdumprd @@ -103,7 +103,9 @@ to_mount() { _t=$(findmnt -k -f -n -r -o TARGET,FSTYPE $_dev) _o=$(findmnt -k -f -n -r -o OPTIONS $_dev) _o=${_o/#ro/rw} #mount fs target as rw in 2nd kernel - _o="${_o},nofail" #with nofail set, systemd won't block for mount failure + # "nofail" mount could be run later than kdump.sh. So we don't pass nofail + # for short term. + #_o="${_o},nofail" #with nofail set, systemd won't block for mount failure _mntopts="$_t $_o" #for non-nfs _dev converting to use udev persistent name if [ -b "$_s" ]; then