From adb585a336a3003dfe1484f53cd3f34cd679b804 Mon Sep 17 00:00:00 2001 From: Hari Bathini Date: Mon, 4 Aug 2014 16:16:36 +0530 Subject: [PATCH] kdumpctl: fix error handling in fadump case In fadump, in case of failure while rebuilding initrd, the error status is not handled properly. See code snippet below: $MKDUMPRD $target_initrd_tmp --rebuild $TARGET_INITRD --kver $kdump_kver \ -i /tmp/fadump.initramfs /etc/fadump.initramfs rm -f /tmp/fadump.initramfs if [ $? != 0 ]; then echo "mkdumprd: failed to rebuild initrd with fadump support" >&2 return 1 fi This patch fixes this issue Signed-off-by: Hari Bathini Acked-by: Vivek Goyal --- kdumpctl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kdumpctl b/kdumpctl index 98de747..2bac6df 100755 --- a/kdumpctl +++ b/kdumpctl @@ -156,11 +156,12 @@ rebuild_fadump_initrd() target_initrd_tmp="$TARGET_INITRD.tmp" $MKDUMPRD $target_initrd_tmp --rebuild $TARGET_INITRD --kver $kdump_kver \ -i /tmp/fadump.initramfs /etc/fadump.initramfs - rm -f /tmp/fadump.initramfs if [ $? != 0 ]; then echo "mkdumprd: failed to rebuild initrd with fadump support" >&2 + rm -f /tmp/fadump.initramfs return 1 fi + rm -f /tmp/fadump.initramfs # updating fadump initrd mv $target_initrd_tmp $TARGET_INITRD